JPA Toplink - what is the need of checking active transaction in the beginning of process?

Question

I've seen few sample on internet that checks whether the transaction is currently active at the beginning of the process.

The code below which is mine get EntityManager from the factory.

I can't figure why would one need to check whether the transaction is active BEFORE it even begin() ???

Is it because some other process may be using the same EntityManager instance? (The EntityManagerFactory is singleton but EntityManager is not)

    @Path("update")
    @PUT
    @Consumes("application/json")
    public Response machineUpdate(String content) {
        JSONObject jObj = null;
        EntityManager em = null;
        EntityTransaction txn = null;

        try {

           JSONObject jObj = new JSONObject(content);
           em = EmProvider.getInstance().getEntityManagerFactory().createEntityManager();

           //what's this line doing here???
           if(em.getTransaction().isActive()) {
               return HttpStatusHandler.sendConflict();
           }

           txn = em.getTransaction();
           txn.begin();
          //more process ......
        }
        catch(.....

score 2 · Accepted Answer · answered Feb 14 '11 at 14:27

2

I can't see any reason for a transaction check, given the code is using the JPA transaction API, there is no way for a transaction to be active given the EntityManager was just created.

If you were using a JTA managed EntityManager, then the JTA transaction could already be active. But for JTA you cannot begin a transaction using JPA Transaction, you would have the begin the transaction with JTA, or use joinTransaction() in JPA.

answered Feb 14 '11 at 14:27

James

17,965
11
91
146

I am not using JTA (disabled in persistences.xml) but based on my research and your statement, that isActive() check in the beginning is not necessary, thanks! – Meow Feb 15 '11 at 11:39

JPA Toplink - what is the need of checking active transaction in the beginning of process?

1 Answers1