update client database for IdentityServer4

Question

I have identityServer4 as my oAuth server in my net core appilication. I was able to initialize my client database using the following code:

    public void Configure(IApplicationBuilder app, IHostingEnvironment env)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
            using (var serviceScope = app.ApplicationServices.GetRequiredService<IServiceScopeFactory>().CreateScope())
            {
                SeedData.EnsureSeedData(serviceScope);
            }
        } 
    }

The migration and client initialization is done using

  public class SeedData
{
    public static void EnsureSeedData(IServiceScope serviceScope)
    {
        Console.WriteLine("Seeding database...");

           serviceScope.ServiceProvider.GetRequiredService<PersistedGrantDbContext>().Database.Migrate();

            var context = serviceScope.ServiceProvider.GetRequiredService<ConfigurationDbContext>();
            context.Database.Migrate();

            EnsureSeedData(context);

        Console.WriteLine("Done seeding database.");
        Console.WriteLine();
    }

    private static void EnsureSeedData(ConfigurationDbContext context)
    {
        if (!context.Clients.Any())
        {
            Console.WriteLine("Clients being populated");
            foreach (var client in Config.GetClients().ToList())
            {
                context.Clients.Add(client.ToEntity());
            }
            context.SaveChanges();
        }
        else
        {
           Console.WriteLine("Clients already populated, update clients");
                foreach (var client in Config.GetClients().ToList())
                {
                    var item = context.Clients.Where(c => c.ClientId == client.ClientId).FirstOrDefault();
                   if(item == null)
                    {
                        context.Clients.Add(client.ToEntity());
                    } else {
                        var model = client.ToEntity();
                        model.Id = item.Id;
                        context.Entry(item).CurrentValues.SetValues(model);
                    }                       
                }
                context.SaveChanges();
            }

            if (!context.IdentityResources.Any())
        {
            Console.WriteLine("IdentityResources being populated");
            foreach (var resource in Config.GetIdentityResources().ToList())
            {
                context.IdentityResources.Add(resource.ToEntity());
            }
            context.SaveChanges();
        }
        else
        {
           Console.WriteLine("IdentityResources already populated");
                foreach (var resource in Config.GetIdentityResources().ToList())
                {
                    var item = context.IdentityResources.Where(c => c.Name == resource.Name).FirstOrDefault();
                    if (item == null)
                    {
                        context.IdentityResources.Add(resource.ToEntity());
                    }
                    else
                    {
                        var model = resource.ToEntity();
                        model.Id = item.Id;
                        context.Entry(item).CurrentValues.SetValues(model);
                    }
                }
                context.SaveChanges();
            }

            if (!context.ApiResources.Any())
        {
            Console.WriteLine("ApiResources being populated");
            foreach (var resource in Config.GetApiResources().ToList())
            {
                context.ApiResources.Add(resource.ToEntity());
            }
            context.SaveChanges();
        }
        else
        {
           Console.WriteLine("ApiResources already populated");
                foreach (var resource in Config.GetApiResources().ToList())
                {
                    var item = context.ApiResources.Where(c => c.Name == resource.Name).FirstOrDefault();
                    if (item == null)
                    {
                        context.ApiResources.Add(resource.ToEntity());
                    }
                    else
                    {
                    var model = resource.ToEntity();
                    model.Id = item.Id;
                    context.Entry(item).CurrentValues.SetValues(model);
                    }
                }
               context.SaveChanges();
            }
    }
}

The initialization of the client database works well. However, there are problems to update the client database. Some of the records are not updated. Is there a better way to do this?

So the insert worked and just the update failed? – aaronR Apr 18 '18 at 14:12 — aaronR, Apr 18 '18 at 14:12
Insert works for all tables. Some tables work for update. – user3097695 Apr 18 '18 at 15:03 — user3097695, Apr 18 '18 at 15:03

score 2 · Accepted Answer · answered Apr 18 '18 at 17:02

After some struggle, I found a solution that works for me. Basically, I created a table, ClientVersion, that track clients definition changes.

Here is my new version of SeedData.cs.

   public class SeedData
{
    public static void EnsureSeedData(IServiceScope serviceScope)
    {
        Console.WriteLine("Seeding database...");

        serviceScope.ServiceProvider.GetRequiredService<PersistedGrantDbContext>().Database.Migrate();

        var context = serviceScope.ServiceProvider.GetRequiredService<ConfigurationDbContext>();
        context.Database.Migrate();

        var versionContext = serviceScope.ServiceProvider.GetRequiredService<VersionContext>();
        versionContext.Database.Migrate();

        EnsureSeedData(context, versionContext);

        Console.WriteLine("Done seeding database.");
        Console.WriteLine();
    }

    private static void EnsureSeedData(ConfigurationDbContext context, VersionContext versionContext)
    {
        ClientVersion version = versionContext.ClientVersion.FirstOrDefault();
        bool blUpdate = version == null ? true : (Config.CurrentVersion > version.Version ? true: false);
        if(blUpdate)
        {
            if(version == null)
            {
                version = new ClientVersion()
                {
                    Version = Config.CurrentVersion,
                };
                versionContext.ClientVersion.Add(version);
            } else
            {
                version.Version = Config.CurrentVersion;
                versionContext.ClientVersion.Update(version);
            }
            versionContext.SaveChanges();
        }
        if (!context.Clients.Any())
        {
            Console.WriteLine("Clients being populated");
            foreach (var client in Config.GetClients().ToList())
            {
                context.Clients.Add(client.ToEntity());
            }
            context.SaveChanges();
        }
        else
        {
            Console.WriteLine("Clients already populated, update clients");
            if (blUpdate)
            {
                foreach (var client in Config.GetClients().ToList())
                {
                    var item = context.Clients
                        .Include(x => x.RedirectUris)
                        .Include(x => x.PostLogoutRedirectUris)
                        .Include(x => x.ClientSecrets)
                        .Include(x => x.Claims)
                        .Include(x => x.AllowedScopes)
                        .Include(x => x.AllowedCorsOrigins)
                        .Include(x => x.AllowedGrantTypes)
                        .Where(c => c.ClientId == client.ClientId).FirstOrDefault();
                    if (item != null)
                    {
                        context.Clients.Remove(item);
                    }
                    context.Clients.Add(client.ToEntity());
                }
                context.SaveChanges();
            }
        }

        if (!context.IdentityResources.Any())
        {
            Console.WriteLine("IdentityResources being populated");
            foreach (var resource in Config.GetIdentityResources().ToList())
            {
                context.IdentityResources.Add(resource.ToEntity());
            }
            context.SaveChanges();
        }
        else
        {
            Console.WriteLine("IdentityResources already populated");
            if (blUpdate)
            {
                foreach (var resource in Config.GetIdentityResources().ToList())
                {
                    var item = context.IdentityResources.Where(c => c.Name == resource.Name).FirstOrDefault();
                    if (item != null)
                    {
                        context.IdentityResources.Remove(item);
                    }
                    context.IdentityResources.Add(resource.ToEntity());
                }
                context.SaveChanges();
            }
        }

        if (!context.ApiResources.Any())
        {
            Console.WriteLine("ApiResources being populated");
            foreach (var resource in Config.GetApiResources().ToList())
            {
                context.ApiResources.Add(resource.ToEntity());
            }
            context.SaveChanges();
        }
        else
        {
            Console.WriteLine("ApiResources already populated");
            if (blUpdate)
            {
                foreach (var resource in Config.GetApiResources().ToList())
                {
                    var item = context.ApiResources.Where(c => c.Name == resource.Name).FirstOrDefault();
                    if (item != null)
                    {
                        context.ApiResources.Remove(item);
                    }
                    context.ApiResources.Add(resource.ToEntity());
                }
                context.SaveChanges();
            }
        }
    }
}

update client database for IdentityServer4

1 Answers1