Greater than and less than in switch statements

Question

I'm trying to figure out why this code does not work

let userName = 'roy';
const userQuestion = 'Do you do CrossFit?';
userName ? console.log('Hello ' + userName + ' !') : console.log('Hello!');
console.log(`The user asked: ${userQuestion}`);
let randomNumber = Math.floor(Math.random() * 8);
let eightBall = '';
console.log(randomNumber);

switch (randomNumber) {
    case 0:
        eightBall = 'It is certain';
        break;
    case 1:
        eightBall = 'It is defidedly so';
        break;
    case randomNumber >= 1:
        eightBall = 'we cant tell';
        break;
}

console.log(` The eight ball answered: ${eightBall}`);

Trying to generate "we can tell" when the number is greater than 1 but it's not printing anything. Am I using a switch statement wrong?

*"Am I using a switch statement wrong?"* - yes. Please read how javascript switch case statement works. — rsm, Apr 17 '18 at 15:15
please do not use a ternary for an expession without assingment rr use of the result. — Nina Scholz, Apr 17 '18 at 15:15

score 2 · Answer 1 · answered Apr 17 '18 at 15:13

2

Use a default with an if statement inside like so:

let randomNumber = 100
let eightBall = ''

switch (randomNumber) {
    case 0:
        eightBall = 'It is certain';
        break;
    case 1:
        eightBall = 'It is defidedly so';
        break;
    default:
        if(randomNumber >= 1)
            eightBall = 'we cant tell';
        break;
}

console.log(` The eight ball answered: ${eightBall}`);

answered Apr 17 '18 at 15:13

Get Off My Lawn

34,175
38
176
338

Given OP's code `randomNumber` will never be negative and the test `if(randomNumber >= 1)` is redundant, it will always be true – phuzi Apr 17 '18 at 15:15

score 2 · Answer 2 · answered Apr 17 '18 at 15:14

2

case takes an argument to be equal too, not a boolean expression. You could just use the default branch:

switch (randomNumber) {
    case 0:
        eightBall = 'It is certain';
        break;
    case 1:
        eightBall = 'It is defidedly so';
        break;
    default: // Here!
        eightBall = 'we cant tell';
        break;
}

answered Apr 17 '18 at 15:14

Mureinik

297,002
52
306
350

It's always good to have an explanation on why the OP's code didn't work, +1 in my books – Huangism Apr 17 '18 at 15:16

Greater than and less than in switch statements

2 Answers2