If statement checking for NSString equality using ==

Question

I am making a server call in some Objective-c code. If it returns as a @"yes", it will do an action. For some reason, the // DO ACTION HERE part is never reached.

NSData *returnData = [NSURLConnection sendSynchronousRequest:request returningResponse:nil error:nil];
NSString *returnString = [[NSString alloc] initWithData:returnData encoding:NSUTF8StringEncoding];
NSString *returnStringResults = returnString;
NSString *yesText = @"yes";

if (returnStringResults == yesText) {
    testLabel.text = @"Success";
    // DO ACTION HERE
}

score 8 · Accepted Answer · edited Feb 14 '11 at 01:25

8

if ([returnStringResults isEqualToString:yesText]) {
    testLabel.text = @"Success";
    // DO ACTION HERE
}

Edit: As bbum pointed out, NSString *returnStringResults = returnString; does nothing.

So really, remove that line and use

if ([returnString isEqualToString:yesText]) {
    testLabel.text = @"Success";
    // DO ACTION HERE
}

edited Feb 14 '11 at 01:25

Dave DeLong

242,470
58
448
498

answered Feb 14 '11 at 00:05

W Dyson

4,604
4
40
68

4

Also `NSString *returnStringResults = returnString;` has no purpose. – bbum Feb 14 '11 at 00:13
Also, you kinda need square brackets when you do method calls. (I added them) – Dave DeLong Feb 14 '11 at 01:25
Thank Dave, I was so focused on the "isEqualToString:" part... My apologies. – W Dyson Feb 14 '11 at 02:59

score 2 · Answer 2 · answered Feb 14 '11 at 00:07

2

You're comparing pointer addresses. The way this code works yesText and returnStringResults are pointers to different NSString instances, thus the pointers are not equal. You've to use NSString isEqualToString method to compare.

answered Feb 14 '11 at 00:07

datenwolf

159,371
13
185
298

If statement checking for NSString equality using ==

2 Answers2

Linked

Related