Need to display ImageIcon when Jbutton is pressed

Question

I am having trouble getting my Image to display when I click my Jbutton, the test sysoutprint works but the Image does not. Any Ideas on what to do I am very lost! The Image is an easter egg for a school project, feel free to make comments. Should I use something besides a ImageIcon or what not? Also if there are any other errors please let me know!

package GUI;
import java.awt.Image;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import javax.swing.ImageIcon;
import javax.swing.JButton;
import javax.swing.JComboBox;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.SwingUtilities;

public class mainView{
private static JFrame main; //main frame we add everything too
private static JPanel newGame; //panel for new game        
private static JPanel dropDownPanel; //panel for the combobox 

private static CardLayout clayout; //cardlayout for new game
private static JComboBox dropDown; //dropdown combobox  
ImageIcon eastImg;





public void codeNameView(){
    main = new JFrame("CodeNames");
    main.setSize(600, 900);
    main.setVisible(true);

    //dropdown menu for quit and new game
    String[] choice = {" " , "NewGame" , "Quit"};
    dropDown = new JComboBox(choice);

    //below is the panel where we add new game and quit options too
    dropDownPanel = new JPanel();
    dropDownPanel.setSize(100, 100);
    dropDownPanel.add(dropDown);
    main.getContentPane().add(dropDownPanel,BorderLayout.NORTH);

    //easter egg
    JButton easterButt = new JButton("Pass CSE 116");
    JLabel eastLbl = new JLabel();
    //added button to JLabel
    eastLbl.add(easterButt);
    try{
        String path = "/Users/nabeelkhalid/git/s18semesterproject-b4-zigzag1/src/GUI/MatthewPhoto.jpg";
        eastImg = new ImageIcon(path);

    }catch(Exception ex){
        System.out.print(ex);
    }
    //added label to Panel
    dropDownPanel.add(eastLbl);
    eastLbl.addMouseListener(new MouseListener(){

        @Override
        public void mouseClicked(MouseEvent e) {
            // TODO Auto-generated method stub
            eastLbl.setIcon(eastImg);
            System.out.print("test");

        }
        //Ignore
        @Override
        public void mousePressed(MouseEvent e) {
            // TODO Auto-generated method stub

        }

        @Override
        public void mouseReleased(MouseEvent e) {
            // TODO Auto-generated method stub

        }

        @Override
        public void mouseEntered(MouseEvent e) {
            // TODO Auto-generated method stub

        }

        @Override
        public void mouseExited(MouseEvent e) {
            // TODO Auto-generated method stub

        }

    });

    //action listener for dropdown combobox
    dropDown.addActionListener(new ActionListener(){

      /**
       * Allows for the user to select New Game or Quit and have the game perform said action
       */
        @Override
        public void actionPerformed(ActionEvent e) {

            // TODO Auto-generated method stub
            JComboBox cb = (JComboBox) e.getSource();
            Object selectedOption = dropDown.getSelectedItem();

            if (selectedOption.equals("Quit")) {
                 main.dispose();    
            }else if(selectedOption.equals("NewGame")){

                codeNameView();
                System.out.print("yolo");

            }
                }

    });

}


public static void main(String[] args) {
    SwingUtilities.invokeLater(new Runnable() {
        @Override
        public void run() {
            mainView x = new mainView();

            // create a instance on mainview to run instead of using static methods

        }
    });
}

}

score 0 · Accepted Answer · edited Jun 20 '20 at 09:12

The primary issue seems to be right here

try{
    String path = "/Users/nabeelkhalid/git/s18semesterproject-b4-zigzag1/src/GUI/MatthewPhoto.jpg";
    eastImg = new ImageIcon(path);

}catch(Exception ex){
    System.out.print(ex);
}

The path is referencing a resource within the context of your src path. You should never reference src in your code, it won't exist once the program is exported (to a Jar or run on a different computer)

Instead, you should consider using Class#getResource to obtain a reference to the image and I'd personally use ImageIO.read over ImageIcon as a personal preference.

try{
    String path = "/GUI/MatthewPhoto.jpg";
    eastImg = new ImageIcon(ImageIO.read(this.getClass().getResource(path)));
}catch(Exception ex){
    System.out.print(ex);
}

And, your next problem is, you're trying to add a JLabel to a JButton, expect, a JButton has not layout manager AND JButton already has support for display an image, so instead, you should be doing something more like...

JButton easterButt = new JButton("Pass CSE 116");
//JLabel eastLbl = new JLabel();
//added button to JLabel
//eastLbl.add(easterButt);
try {
    String path = "/GUI/MatthewPhoto.jpg";
    eastImg = new ImageIcon(ImageIO.read(this.getClass().getResource(path)));

} catch (Exception ex) {
    System.out.print(ex);
}
//added label to Panel
dropDownPanel.add(easterButt);
easterButt.addActionListener(new ActionListener() {
    @Override
    public void actionPerformed(ActionEvent e) {
        easterButt.setIcon(eastImg);
    }
});

You really should take a closer look at How to Use Buttons, Check Boxes, and Radio Buttons

Test Code

This is the code I used to test the solutions suggested above

import java.awt.BorderLayout;
import java.awt.CardLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.imageio.ImageIO;
import javax.swing.ImageIcon;
import javax.swing.JButton;
import javax.swing.JComboBox;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.SwingUtilities;

public class mainView {

    private static JFrame main; //main frame we add everything too
    private static JPanel newGame; //panel for new game        
    private static JPanel dropDownPanel; //panel for the combobox 

    private static CardLayout clayout; //cardlayout for new game
    private static JComboBox dropDown; //dropdown combobox  
    ImageIcon eastImg;

    public void codeNameView() {
        main = new JFrame("CodeNames");
        main.setSize(600, 900);

        //dropdown menu for quit and new game
        String[] choice = {" ", "NewGame", "Quit"};
        dropDown = new JComboBox(choice);

        //below is the panel where we add new game and quit options too
        dropDownPanel = new JPanel();
        dropDownPanel.setSize(100, 100);
        dropDownPanel.add(dropDown);
        main.getContentPane().add(dropDownPanel, BorderLayout.NORTH);

        //easter egg
        JButton easterButt = new JButton("Pass CSE 116");
//      JLabel eastLbl = new JLabel();
//      //added button to JLabel
//      eastLbl.add(easterButt);
        try {
            String path = "/GUI/MatthewPhoto.jpg";
            eastImg = new ImageIcon(ImageIO.read(this.getClass().getResource(path)));

        } catch (Exception ex) {
            System.out.print(ex);
        }
        //added label to Panel
        dropDownPanel.add(easterButt);
        easterButt.addActionListener(new ActionListener() {
            @Override
            public void actionPerformed(ActionEvent e) {
                easterButt.setIcon(eastImg);
            }
        });

        //action listener for dropdown combobox
        dropDown.addActionListener(new ActionListener() {

            /**
             * Allows for the user to select New Game or Quit and have the game
             * perform said action
             */
            @Override
            public void actionPerformed(ActionEvent e) {

                // TODO Auto-generated method stub
                JComboBox cb = (JComboBox) e.getSource();
                Object selectedOption = dropDown.getSelectedItem();

                if (selectedOption.equals("Quit")) {
                    main.dispose();
                } else if (selectedOption.equals("NewGame")) {

                    codeNameView();
                    System.out.print("yolo");

                }
            }

        });
        main.setVisible(true);

    }

    public static void main(String[] args) {
        SwingUtilities.invokeLater(new Runnable() {
            @Override
            public void run() {
                System.out.println("Hello");
                mainView x = new mainView();
                x.codeNameView();
                // create a instance on mainview to run instead of using static methods
            }
        });
    }
}

Implemented your try catch block but the mouse listener test works and the image does not get displayed, could it be an issue with my Label? — Nabeel Khalid, Apr 14 '18 at 22:13
I implemented all of your code but the test still passes and I took the time to read the page you linked but still cannot get the picture to display. — Nabeel Khalid, Apr 14 '18 at 22:24

score -1 · Answer 2 · answered Apr 14 '18 at 21:57

-1

Try using something like this:
String path = "C:\\Users\\nabeelkhalid\\git\\s18semesterproject-b4-zigzag1\\src\\GUI\\MatthewPhoto.jpg";

answered Apr 14 '18 at 21:57

pritam parab

85
2
10

The path is a unix path, converting it to a windows path isn't going help – MadProgrammer Apr 14 '18 at 22:02

Need to display ImageIcon when Jbutton is pressed

2 Answers2

Test Code