Delete original file after zipping it

Question

I am looping through a directory and zip the files in it. In the following code, I am adding the original file to a zipOutputStream, and then delete the file. With the code below, I get the following exception:

    Exception thrown: 'System.IO.IOException' in mscorlib.dll
System.IO.IOException: The process cannot access the file 'C:\Users\Desktop\test.zip' because it is being used by another process.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   at System.IO.File.OpenRead(String path)
   at ZipFiles.zipFile(String fileToZip, ZipOutputStream oStream) in C:\Users\Desktop\CodeFile1.cs:line 34
   at ZipFiles.zipByFileSize(String dir) in C:\Users\Desktop\CodeFile1.cs:line 75

I understand that this exception occurs because the file is being zipped and I am deleting it at the same time? if so, how do I make sure that the zipping happens before the deleting?

Here is my code:

try
                {
                    using (ZipOutputStream oStream = new ZipOutputStream(File.Create(zipPath)))
                    {
                        oStream.SetLevel(8); // 9 = highest compression
                        for (int j = 0; j < i; j++)
                        {
                            string fileToZip = sorted.ElementAt(j);
                            zipFile(fileToZip, oStream);


                            File.Delete(fileToZip);
                        }

                        oStream.Finish();
                        oStream.Close();
                    }


                    // limitIndex = i - 1;
                    startIndex = i - 1;
                    zipNumber += 1;
                    size = 0;
                }
                catch (Exception ex)
                {
                    Debug.WriteLine(ex.ToString());
                }

I am using the following libraries:

using System;
using System.Diagnostics;
using System.IO;
using System.Linq;
using ICSharpCode.SharpZipLib.Core;
using ICSharpCode.SharpZipLib.Zip;

score 2 · Answer 1 · answered Mar 28 '18 at 15:43

How about running a second loop to do the deleting after you've done all of the zipping?

try
{
  using (ZipOutputStream oStream = new ZipOutputStream(File.Create(zipPath)))
  {
    oStream.SetLevel(8); // 9 = highest compression
    for (int j = 0; j < i; j++)
    {
        string fileToZip = sorted.ElementAt(j);
        zipFile(fileToZip, oStream);
    }

    oStream.Finish();
    oStream.Close();
  }

  // Delete the files now.
  for (int j = 0; j < i; j++)
  {
    string fileToZip = sorted.ElementAt(j);
    File.Delete(fileToZip);
  }


  // limitIndex = i - 1;
  startIndex = i - 1;
  zipNumber += 1;
  size = 0;
}
catch (Exception ex)
{
  Debug.WriteLine(ex.ToString());
}

This didn't work for me: as I was deleting the file in my "sorted" variable, the length of sorted changed. I found a work around: i check if a file is already in a zip file, then I delete the file in the original directory. — AntsaR, Mar 28 '18 at 21:41

Delete original file after zipping it

1 Answers1