Is there a way to clean up this code to make it more efficient and not look so messy?

Question

I have 2 .jpg pictures that I am sending. They both are called as follows: 'wow1', 'wow2'. The code below works when I send it, but it doesn't look very pretty. How can I clean this up?

for n in range (1,3):
    address = 'http://exampleaddress.com/rowdycode/wow'
    extension = '.jpg'
    picture =str(n)
    p = str(address+picture+extension)
    media_url = p

If I give it a print function, it prints as follows:

http://exampleaddress.com/rowdycode/wow1.jpg
http://exampleaddress.com/rowdycode/wow2.jpg

Thank you in advance.

I think [codereview](https://codereview.stackexchange.com/) would have been better suited to answer a question like this — smac89, Mar 23 '18 at 18:03
What does this question have to do with the `twilio` and `mms` tags? — smac89, Mar 23 '18 at 18:05

score 2 · Answer 1 · answered Mar 23 '18 at 18:01

2

You can use str.format

Ex:

for n in range (1,3):
    media_url = 'http://exampleaddress.com/rowdycode/wow{0}.jpg'.format(n)

answered Mar 23 '18 at 18:01

Rakesh

81,458
17
76
113

Alternatively, if @arekenny3 is using python 3.6 or greater he can use fstrings. for n in range (1,3): media_url = f"http://exampleaddress.com/rowdycode/wow{n}.jpg" – Peter Dolan Mar 23 '18 at 18:01

score 1 · Answer 2 · answered Mar 23 '18 at 18:04

1

you can use like

for n in range (1,3):
    address = 'http://exampleaddress.com/rowdycode/wow%d.jpg'%(n)

answered Mar 23 '18 at 18:04

Syed Ali

219
3
11

score 1 · Accepted Answer · answered Mar 23 '18 at 18:06

1

From python 3.6, you can also use Literal String Interpolation(f-strings)

address = [f'http://exampleaddress.com/rowdycode/wow{n}.jpg' for n in range(1,3)]

answered Mar 23 '18 at 18:06

Minje Jeon

121
5

score 0 · Answer 4 · answered Mar 23 '18 at 18:09

Store the results (i.e. addresses) it using a list comprehension.

my_list = ['http://exampleaddress.com/rowdycode/wow{}.jpg'.format(n) for n in range(1,3)]

or we can use f-strings (Introduced in Python 3.6)

my_list = [f'http://exampleaddress.com/rowdycode/wow{n}.jpg' for n in range(1,3)]


# print(my_list) for testing purposes

Doing the same within a for loop:

for n in range(1,3):
    address = f'http://exampleaddress.com/rowdycode/wow{n}.jpg'
    # print (address)

Is there a way to clean up this code to make it more efficient and not look so messy?

4 Answers4