Calling second request after first one is finished

Question

I have a question about requests.I make first request then I suppose first onSuccess method will be runnning but program make second request immediately.How can i handle it? Context.getAlarmGroupById is called 2 times immediately. my code:

        function loadAll () {
        Context.getAlarmGroupChainById({
            id: $stateParams.id
        }, onSuccess, onError);


            function onSuccess(data, headers) {
            vm.temp=data; 
            var numberGroupChain=vm.temp.length;
            for(var i=0; i<numberGroupChain; i++){
                vm.location.push(vm.temp[i].location);
                vm.alarmChainList.push({name: vm.location[i],active:null,totalAlarmGroupNumber:null});             
                //loadData(vm.temp[i].id);
                asyncLoop(vm.temp[i].id);
              }
            }


            function onError(error) {
              AlertService.error(error.data.message);
            }

        var index = 0;

        function asyncLoop(chainId) {
            if(index >= vm.temp.length) {
                return;
            }
         Context.getAlarmGroupById({
             id:chainId
         }, onSuccess, onError);


             function onSuccess(data,headers){
                 index++;
                 asyncLoop();
             }

             function onError(data,headers){
                 index++;
                 asyncLoop();
             }
        }

    }

Check the [promise](https://docs.angularjs.org/api/ng/service/$q). — Kaustubh Khare, Mar 22 '18 at 06:42
Please check https://stackoverflow.com/questions/32546248/chain-angular-http-calls-properly — Alexis, Mar 22 '18 at 06:52
Don't call a service in a loop. Make a method Car.getGroupIds(vm.temp) that returns a list that you can filter. — gyc, Mar 22 '18 at 07:21

I. Ahmed · Accepted Answer · 2018-03-22T08:29:11.913

Firstly: Car.getGroupId is an asynchronous function. So you have to ensure that the previous call is completed, before the next call.

Secondly: The recursive function is created for replacing the loop, after the success function and index increment, the recursive function is called to ensure your required requirement.

Third: Change the calling sequence of asyncLoop(vm.temp[i].id); after loop:

Finally:

Please use the following code:

function loadAll () {

    var index = 0;

    function asyncLoop(chainId) {
        if(index >= vm.temp.length) {
            return;
        }
     Context.getAlarmGroupById({
         id:vm.temp[index].id
     }, onSuccess, onError);


         function onSuccess(data,headers){
             index++;
             asyncLoop();
         }

         function onError(data,headers){
             index++;
             asyncLoop();
         }
    }

    function onSuccessParent(data, headers) {
        vm.temp=data; 
        var numberGroupChain=vm.temp.length;
        for(var i=0; i<numberGroupChain; i++){
            vm.location.push(vm.temp[i].location);
            vm.alarmChainList.push({name: vm.location[i],active:null,totalAlarmGroupNumber:null});             
            //loadData(vm.temp[i].id);

          }
          asyncLoop();
    }


    function onErrorParent(error) {
          AlertService.error(error.data.message);
    }

    Context.getAlarmGroupChainById({
        id: $stateParams.id
    }, onSuccessParent, onErrorParent);

}

I cannot implement your code to my code:( function has to get a parameter but i cannot add it — Belhanda, Mar 22 '18 at 07:46
loadData(vm.temp[i].id); id need not to pass as vm is global variable. — I. Ahmed, Mar 22 '18 at 07:50
It is not working.It call 2 times again before enter the onSuccess.I loaded last update code.Can you help me? — Belhanda, Mar 22 '18 at 08:11
Context.getAlarmGroupById is called two times before onSuccess method. — Belhanda, Mar 22 '18 at 08:12

score 0 · Answer 2 · answered Mar 22 '18 at 08:10

0

Here is the pure JavaScript way to do this and it works perfectly fine. Use Promise.then(). Do like below:

var request1 = new Promise(function(resolve, reject) {
  resolve('Success!');
});

request1.then(function(value) {
  // make request2 here
});

answered Mar 22 '18 at 08:10

Vikasdeep Singh

20,983
15
78
104

Calling second request after first one is finished

2 Answers2