RecyclerView won't update child until I scroll

Question

I think I've read pretty much all the answers to all of the similar SO questions, and NONE of them seem to be working for me. It's driving me nuts, and I've spent too much time on this.

I'm implementing a RecyclerView here and I can't for the life of me update it's children. What happens is that after I update nothing changes on the screen, UNLESS I start scrolling. Once I scroll it updates perfectly.

This is my code:

public void updateDataAtIndex(final int indexToUpdate, ReadableMap updatedChild) {
    if (updatedChild != null) {
        if (this.data != null && this.data.size() > indexToUpdate) {
            this.data.set(indexToUpdate, updatedChild);
            final SPAdapter self = this;
            new Handler(Looper.getMainLooper()).post(new Runnable() {
                public void run() {
                    System.out.println("\n@@@@@@@@@@@@@@@@@ Updating: "+indexToUpdate);
                    self.notifyItemChanged(indexToUpdate);
                }
            });
        }
    }
}

Here's the full adapter: https://github.com/SudoPlz/react-native-synchronous-list/blob/master/lib/android/src/main/java/com/sudoplz/rnsynchronouslistmanager/Views/List/SPAdapter.java#L109

SudoPlz · Accepted Answer · 2019-05-31T20:49:32.420

12

That was a react-native issue ¯\_(ツ)_/¯.

I've resolved this by intercepting requestLayout like so:

protected boolean mRequestedLayout = false;

@Override
    public void requestLayout() {
        super.requestLayout();
        // We need to intercept this method because if we don't our children will never update
        // Check https://stackoverflow.com/questions/49371866/recyclerview-wont-update-child-until-i-scroll
        if (!mRequestedLayout) {
            mRequestedLayout = true;
            this.post(new Runnable() {
                @SuppressLint("WrongCall")
                @Override
                public void run() {
                    mRequestedLayout = false;
                    layout(getLeft(), getTop(), getRight(), getBottom());
                    onLayout(false, getLeft(), getTop(), getRight(), getBottom());
                }
            });
        }
    }

FINALLY it works.. Credit goes to this unsung hero who discovered the workaround.

edited May 31 '19 at 20:49

answered Mar 19 '18 at 21:33

SudoPlz

20,996
12
82
123

1

This works! I was having the same issue, thank you. I'd mention that you need to declare mRequestedLayout somewhere. – Florian Cargoet Apr 04 '18 at 16:43
Thanks a lot. You save me a lot of pain. – Daniel Jose Padilla Peña May 31 '19 at 19:59
I'm super happy to hear that @DanielJosePadillaPeña – SudoPlz May 31 '19 at 20:48
For me, I didn't even see `refreshLayout` called until I scrolled. – AdamMc331 Dec 19 '19 at 18:13
https://github.com/react-native-community/react-native-viewpager/issues/118 Thank you so much <3 – Piotr Badura Feb 02 '20 at 11:45

RecyclerView won't update child until I scroll

1 Answers1

Linked