Troubles wtih comments in XmlSerialzier

Question

I try to load a XML file with this code:

XmlSerializer xmlSerializer = new XmlSerializer(typeof(MyObject));
StreamReader reader = new StreamReader(fileName);
object myobject = xmlSerializer.Deserialize(reader);

When the file contains a comment like this:

<?xml version="1.0" encoding="utf-8"?>
<!-- edited with XMLSpy v2007 sp2  -->
<route>
    <!--File created on 26-Nov-2010 12:36:42-->
    <file_content>1
    <!--0 = type1 ; 1 = type2-->
    </file_content>
</route>

XmlSerializer returns an error like

Unexpected node type Comment. ReadElementString method can only be called on elements with simple or empty content

When I remove this comments in file it's work fine.

I don´t know where is the problem, any ideas?

can you try to put the comment inside the element ? I think the xml parser requires to have the first node to be the root element — Steve B, Feb 07 '11 at 08:48
Sorry, but I'm not decided the file format, it's from a provider, and I'm traying to parse whitouth no changes in his format. — Dav, Feb 07 '11 at 08:52
Anyway, I think that the problem is in line 5 : "1" maybe its because the comment is inside the element "file_content" — Dav, Feb 07 '11 at 09:02

score 6 · Answer 1 · answered Feb 07 '11 at 09:22

As you can see comments are not allowed in the serialized XML, but this should pose no problem for you. You might not control the source XML but you control the deserialization process, so simply remove all comments prior to deserialization:

    XmlSerializer xmlSerializer = new XmlSerializer(typeof(myobject));

    // load document
    XmlDocument doc = new XmlDocument();
    doc.Load(filename);

    // remove all comments
    XmlNodeList l = doc.SelectNodes("//comment()");
    foreach (XmlNode node in l) node.ParentNode.RemoveChild(node);

    // store to memory stream and rewind
    MemoryStream ms = new MemoryStream();
    doc.Save(ms);
    ms.Seek(0, SeekOrigin.Begin);

    // deserialize using clean xml
    xmlSerializer.Deserialize(XmlReader.Create(ms));

If your objects are huge and you deserialize a huge number of them in short span, howler, we can investigate some out-of-framework fast Xpath readers.

ok, thanks, If my provider can't change the original format for files, I'll take your solution — Dav, Feb 07 '11 at 09:26

score 4 · Answer 2 · answered Jul 24 '14 at 01:52

I agree with @mmix, you will have to remove the comments before trying to serialize it.

May be another way to remove comments, could be to use XmlReader with XmlReaderSettings

    public static T DeSerialize<T>(string filePath)
    {
        var x = new XmlSerializer(typeof (T));

        //Serilaize would fail if there are comments in the xml document
        var xmlReaderSettings = new XmlReaderSettings {IgnoreComments = true};
        var xmlReader = XmlReader.Create(filePath, xmlReaderSettings);

        return (T)x.Deserialize(xmlReader);
    }

score 0 · Answer 3 · answered Oct 15 '16 at 17:47

I find jacob aloysious the most elegant answer for the problem. It also works when reading RSS feeds using System.ServiceModel.SyndicationFeed.Load function. Example below:

public SyndicationFeed GetFeed(String url)
{
    var request = (HttpWebRequest)WebRequest.Create(url);
    using (var response = request.GetResponse())
    using (var responseStream = response.GetResponseStream())
    {
        Debug.Assert(responseStream != null, "responseStream != null");

        var xmlReaderSettings = new XmlReaderSettings { IgnoreComments = true };
        using (XmlReader xmlReader = XmlReader.Create(responseStream, xmlReaderSettings))
        {
            var feed = SyndicationFeed.Load(xmlReader);
            return feed;
        }
    }
}

Troubles wtih comments in XmlSerialzier

3 Answers3