Laravel Jobs Serialization of 'Closure' is not allowed

Question

I would like to send Data to a NewsletterStore Job. But it's failing with the following error. Any suggestions?

I also tried to remove the SerializesModels Models trait. Without any success.

Error

Exception
Serialization of 'Closure' is not allowed

Controller

 public function store(StoreNewsletterRequest $request)
    {
        StoreNewsletterJob::dispatch($request);

        return view('backend.dashboard.index');
    }

Job

protected $request;

    public function __construct($request)
    {
        $this->request = $request;
    }

    /**
     * Execute the job.
     *
     * @return void
     */

    public function handle()
    {
        if(!Newsletter::isSubscribed($this->request->email))
        {

            Newsletter::subscribe($this->request->email, [

                config('newsletter.list_fields.firstname') => $this->request->firstname,
                config('newsletter.list_fields.lastname') => $this->request->lastname

            ]);
        }
    }

It needs to serialize objects into wherever your sending the jobs so they can be reconstructed when the job runs. The Request class isn't serializable hence why you get the error. Models are serializable by default so work without problems. There's a few ways you could fix it. The obvious one is to make sure the object you pass in is serializable but If your only interested in those 3 attributes the easy fix would be to pass them into the constructor ignoring objects altogether. — Dave Carruthers, Mar 07 '18 at 17:51

FULL STACK DEV · Accepted Answer · 2018-03-07T19:04:38.133

19

Request is not serializable there is a workaround what you are trying to achieve

 public function store(StoreNewsletterRequest $request)
{
    StoreNewsletterJob::dispatch($request->all());

    return view('backend.dashboard.index');
}

Your job handler.

 public function handle()
{
    if(!Newsletter::isSubscribed($this->request['email']))
    {

        Newsletter::subscribe($this->request['email'], [

            config('newsletter.list_fields.firstname') => $this->request->firstname,
            config('newsletter.list_fields.lastname') => $this->request->lastname

        ]);
    }
}

Hope this helps

edited Mar 07 '18 at 19:04

answered Mar 07 '18 at 18:25

FULL STACK DEV

15,207
5
46
66

6

Some explanation of what the workaround actually is and does would be useful – Hashim Aziz Feb 19 '22 at 21:16

score 2 · Answer 2 · answered Mar 29 '21 at 13:47

2

Another possibility for this if you still want access to many of the familiar methods 'only, get' etc you can just

collect($request->all());

And use it as a collection instead

answered Mar 29 '21 at 13:47

MHewison

846
10
17

1

Nice and simple. – Hashim Aziz Feb 19 '22 at 21:18

score 1 · Answer 3 · answered Mar 07 '18 at 21:50

I followed another approach, Just to may help you out!

Controller

  $newsletter = (object) array(

                'email' => $request->email,
                'firstname' => $request->firstname,
                'lastname' => $request->lastname,

            );

   StoreNewsletterJob::dispatch($newsletter);

Job

protected $newsletter;

    public function __construct( object $newsletter)
    {
        $this->newsletter = $newsletter;
    }

    /**
     * Execute the job.
     *
     * @return void
     */

    public function handle()
    {

        if(!Newsletter::isSubscribed($this->newsletter->email))
        {
            Newsletter::subscribe($this->newsletter->email, [

                config('newsletter.list_fields.firstname') => $this->newsletter->firstname,
                config('newsletter.list_fields.lastname') => $this->newsletter->lastname

            ]);
        }
    }

Laravel Jobs Serialization of 'Closure' is not allowed

3 Answers3

Linked