1

I am attempting to use Uncrustify on a project of mine, but I am running into some issues with spacing changes that it makes when a macro is used as the receiver of an Objective-C message. For example, given the following macro and method call, I would expect the spacing to remain exactly as is.

#define NilOrNotNSNull(val) ({id __val = (val); (__val == [NSNull null]) ? nil : __val;})

title_ = [NilOrNotNSNull([dict objectForKey:@"post_title"]) copy];

However, this is the result.

#define NilOrNotNSNull(val) ({id __val = (val); (__val == [NSNull null]) ? nil : __val;})

title_ = [NilOrNotNSNull ([dict objectForKey:@"post_title"])copy];

It appears as if Uncrustify does not recognize that the text in parentheses is an argument for the macro, but then I'm not really sure what the heck it thinks it is. This seems like an Uncrustify bug to me, but it could be an issue with my config, so I figured I'd ask here as well as filing an issue on GitHub. Here is the config I'm using: https://gist.github.com/812314

If anyone could offer some insight, I'd appreciate it.

Bryan Henry
  • 8,348
  • 3
  • 34
  • 30

1 Answers1

1

I don't get your exact output when I run using your config. What version are you using? My version output is as follows:

macbook-adamd:~ adamd$ uncrustify --version
uncrustify 0.56

The output that I get using your config has a backslash that wraps your macro's close parent to a newline: 

#define NilOrNotNSNull(val) ({ id __val = (val); (__val == [NSNull null]) ? nil : __val; } \
                         )

title_ = [NilOrNotNSNull ([dict objectForKey:@"post_title"])copy];

That said, I was able to eliminate the space between NilOrNotNSNull and the open paren by adding set func_call_user NilOrNotNSNull to the top of the config file. See the documentation for the sp_func_call_user_paren for more information. It seems you have the option set up to remove the space, just no definitions for it to match.

Here is my output with the set func_call_user NilOrNotNSNull :

#define NilOrNotNSNull(val) ({ id __val = (val); (__val == [NSNull null]) ? nil : __val; } \
                             )

title_ = [NilOrNotNSNull([dict objectForKey:@"post_title"]) copy];

I forked your gist and updated it: https://gist.github.com/815042

Adam
  • 890
  • 4
  • 10
  • Ah, great. That's kind of a workaround, in my opinion, but it works I suppose. Hopefully someone will follow up with my issue on Github to comment on whether that is intended or not. And yes, you're right, my output example wasn't exactly correct. :) I pulled the macro define out of my pre-compile header which doesn't run through Uncrustify, so I didn't realize it did that. – Bryan Henry Feb 07 '11 at 20:49
  • On second thought, this workaround would mean adding the name of every single function and macro in my project manually to the uncrustify config. That's not really a satisfactory solution. – Bryan Henry Feb 08 '11 at 04:55