How to draw blocks in Tetris with less code?

Question

Is there a way to do the print "0" part with less code? I tried various things, but I just crazy random prints. If I try a for loop with a variable that lets the BlockX array move up every time it prints a "0" it just flips out. even if I cap that variable at 3.

TIA

Edit: BlockX and BlockY are coordinates of blocks. Coordinates are defined somewhere else.

void Draw()
{

system("cls");
for (int i = 0; i < height + 1; i++)
{
    for (int j = 0; j < width + 1; j++)
    {
        if (j == 10)
        {
            cout << "|";
        }
        if (j == width)
        {
            cout << "|";
        }
        else if ((j == BlockX[0] && i == BlockY[0]) || (j == BlockX[1] && i == BlockY[1]) || (j == BlockX[2] && i == BlockY[2]) || (j == BlockX[3] && i == BlockY[3]))
        {
            cout << "0";                            
        }
        else
        {       
            cout << " ";
        }               
    }
    cout << endl;
}

They are coordinates of blocks that need to be printed. They are defined somewhere else. It is always an array of 4 items with different coordinates depending on which type of block is generated. — TheProgramMAN123, Feb 28 '18 at 01:03
If nothing else, consider wrapping it up into a function `IsBlockCoordinate(i, j)` or something — Tas, Feb 28 '18 at 01:10
`j==10` and `j==width` are two distinct possibilities? The reason I ask is because every other condition is `if { } else { }` and if for some reason `j == 10 == width` you will be printing two `|`. — Justin Randall, Feb 28 '18 at 01:20

Justin Randall · Accepted Answer · 2018-02-28T02:02:42.620

1

To expand on Tas' thought, you could write a function to check those coordinates like this.

bool isBlockCoordinate(int i, int j)
{
    return ((j == BlockX[0] && i == BlockY[0]) ||
            (j == BlockX[1] && i == BlockY[1]) ||
            (j == BlockX[2] && i == BlockY[2]) ||
            (j == BlockX[3] && i == BlockY[3]));
}

And you could invoke it within your loop like this:

    if (j == width)
    {
        cout << "|";
    }
    else if (isBlockCoordinate(i, j))
    {
        cout << "0";                            
    }
    else
    {       
        cout << " ";
    }

edited Feb 28 '18 at 02:02

answered Feb 28 '18 at 01:25

Justin Randall

2,243
2
16
23

Sorry I am a bit new with C++, could you elaborate a bit how I would work this into the loop? I get an error, expecting an ;. – TheProgramMAN123 Feb 28 '18 at 02:00
I was stupid, I wrote the function inside the draw function. This solution works perfectly, thanks! – TheProgramMAN123 Feb 28 '18 at 02:18
@TheProgramMAN123 You're welcome, I'm glad to hear it's working for you. – Justin Randall Feb 28 '18 at 02:34

How to draw blocks in Tetris with less code?

1 Answers1