Add checked = true via programming

Question

I have been adding items to tool strip by programming but the issue is that I need to add checked property to it. Do not know how to do so. Here is the code:

toolStripMenuItemAudioSampleRate.DropDownItems.Add("8 kHz", null, new EventHandler(mnuAudioSamplingRate_Click));
toolStripMenuItemAudioSampleRate.Checked = (samplingRate == 8000);//Checks if the there is no vid device

Now I know that it will work wrong because I have added checked property to toolStripMenuItemAudioSampleRate not the 8 kHz. I am trying to add this property to the dynamically added items.

Thanks in advance.

When you say "add this property", I assume you mean "set this property". Am I correct in saying that? — siride, Feb 04 '11 at 19:18
yes you are correct i am not native english speaker so mistakes are always there — Afnan Bashir, Feb 04 '11 at 19:27

unholysampler · Answer 1 · 2011-02-04T19:41:00.297

5

Instead of using the Add(String, Image, EventHandler) helper method to create the drop down item, make your own ToolStripMenuItem, set it to checked, and then add it to the list.

ToolStripMenuItem item = new ToolStripMenuItem("8 kHz", null, new EventHandler(mnuAudioSamplingRate_Click));
item.Checked = (samplingRate == 8000);
toolStripMenuItemAudioSampleRate.DropDownItems.Add(item);

edited Feb 04 '11 at 19:41

answered Feb 04 '11 at 19:16

unholysampler

17,141
7
47
64

since when does ToolStripItem's class have a Checked property? http://msdn.microsoft.com/en-us/library/system.windows.forms.toolstripitem.aspx – Jean-Christophe Fortin Feb 04 '11 at 19:28
@Jean-Christophe Fortin: Edited to reflect that you need `ToolStripMenuItem` for checked. I didn't spend enough time on msdn to see that `ToolStripItem` was a parent class since no class names were used in the OP. – unholysampler Feb 04 '11 at 19:44

score 2 · Accepted Answer · edited May 23 '17 at 12:04

2

To make this code fancier, I suggest removing new EventHandler, which is always redundant, and using object initializer:

toolStripMenuItemAudioSampleRate.DropDownItems.Add (
    new ToolStripMenuItem ("8 kHz", null, mnuAudioSamplingRate_Click) {
        Checked = (samplingRate == 8000)
    });

edited May 23 '17 at 12:04

Community

1
1

answered Feb 04 '11 at 19:24

Dan Abramov

264,556
84
409
511

gud style worked by little modification that is instead of 'ToolStripItem' replaced 'ToolStripMenuItem' – Afnan Bashir Feb 04 '11 at 19:48
Im Loving it.It simply reduced my LOC to Half.Great! – Afnan Bashir Feb 04 '11 at 20:03

score 0 · Answer 3 · answered Feb 04 '11 at 19:17

toolStripMenuItemAudioSampleRate.DropDownItems["8 kHz"].Checked = (samplingRate == 8000)

That might do what you want. It might be a good idea to hold on to these dynamically added items in an array somewhere, so that you don't have to use this ugly syntax.

Jean-Christophe Fortin · Answer 4 · 2011-02-04T19:40:19.640

-1

You can create an Decorator(GOF Design Pattern) http://www.exciton.cs.rice.edu/JavaResources/DesignPatterns/book/hires/pat4dfso.htm

edited Feb 04 '11 at 19:40

answered Feb 04 '11 at 19:16

Jean-Christophe Fortin

756
6
17

At least can I know why you VoteDown ? The Adapter Pattern is made for adding responsibilities to individual objects dynamically and transparently. – Jean-Christophe Fortin Feb 04 '11 at 19:21
I didn't vote down but I too can see no connection between Adapter pattern and the question being asked. – Dan Abramov Feb 04 '11 at 19:25
`ToolStripMenuItem` is standard framework class and already has desired functionality, he just needed to set its property. – Dan Abramov Feb 04 '11 at 19:26
Oups.. you're right it's the Decorator pattern I want to say. Otherwise, at first @Afnan say he want to "add" the property to a object which it exactly what the Decorator(my mistake) does. I wasn't aware that ToolStripMenuItem have already the property. – Jean-Christophe Fortin Feb 04 '11 at 19:40

Add checked = true via programming

4 Answers4