Unreachable code detected after transaction

Question

I'm getting the warning 'Unreachable code detected' in my typescript file. Nothing works after running a Firebase transaction. Here's the transaction code:

// Create Firestore reference
let pointsRef = 'Users/'+this.user.uid;
var pointsDocRef = this.afs.doc(pointsRef).ref;

return this.afs.firestore.runTransaction((transaction) => {
  return transaction.get(pointsDocRef).then((ptsDoc) => {
    if(!ptsDoc.exists){
      throw "Document does not exist!"
    }

    var newPtsScore = ptsDoc.data().points - 20;
    transaction.update(pointsDocRef, { points: newPtsScore });             
  });
}).then(() => {
  console.log('Point count successfully decremented for new item'); 
  // Close dialog
  this.dialog.closeAll();
}).catch(function(error) {console.log('Transaction failed: ', error);});

console.log('Hey there!'); <-- "UNREACHABLE CODE DETECTED"

You have a return just above : return this.afs.... – David Feb 18 '18 at 20:52 — David, Feb 18 '18 at 20:52

score 5 · Answer 1 · answered Feb 18 '18 at 20:51

5

Your log line is immediately after a return statement. It line will never run because return leaves the function.

answered Feb 18 '18 at 20:51

Doug Stevenson

297,357
32
422
441

Which return statement? – FiringBlanks Feb 18 '18 at 20:52
The one at the same column as the log line. The first one. The second one within a different function. – Doug Stevenson Feb 18 '18 at 20:53
@FiringBlanks `return this.afs.firestore 5])...` is all one return, then you're trying to print after the function has returned. – Carcigenicate Feb 18 '18 at 20:55
That's how a transaction is done according to the docs. Does this mean that every file can only have one transaction and no code after it? – FiringBlanks Feb 18 '18 at 20:55
@FiringBlanks Do you have to return the result of `runTransaction`? – Carcigenicate Feb 18 '18 at 20:56
According to the [docs](https://firebase.google.com/docs/firestore/manage-data/transactions), yes. – FiringBlanks Feb 18 '18 at 20:57

Unreachable code detected after transaction

1 Answers1