Undefined variable. Laravel

Question

I am trying to filter my results. For this i have following query:

$destinations = $request['destinations'];
        if($request->has('destinations'))
        {
            $trips = Trip::where('status','=',1)->whereHas('destinations', function($q) {
            $q->where('destinationsid', '=', $destinations);
            })->get();
        }else{
             echo "No destination provided";
        }

But I'm getting undefined variable $destinations. If i replace $destinations with any id (6) it shows results. I have also tried to echo $destinations outside the query, it is returning array. What is wrong here? Can anyone help me?

score 3 · Accepted Answer · edited Feb 12 '18 at 06:22

Try to add the use($destination) after function($q):

$destinations = $request['destinations'];

if($request->has('destinations'))
{
     $trips = Trip::where('status','=',1)->whereHas('destinations', function($q) use($destinations) {
        $q->where('destinationsid', '=', $destinations);
     })->get();
} else {
        echo "No destination provided";
}

Alexey Mezenin · Answer 2 · 2018-02-12T05:40:31.747

You need to add use() to the closure to pass variables. For example:

->whereHas('destinations', function($q) use($destinations) {

Or, you could just use the request() global helper:

->whereHas('destinations', function($q) {
    $q->where('destinationsid', request('destinations'));

From the docs:

Closures may also inherit variables from the parent scope. Any such variables must be passed to the use language construct.

score 1 · Answer 3 · answered Feb 12 '18 at 05:34

You need to pass destinations variable in your where closure:

$destinations = $request['destinations'];
    if($request->has('destinations'))
    {
        $trips = Trip::where('status','=',1)->whereHas('destinations', function($q) use ($destinations){
        $q->where('destinationsid', '=', $destinations);
        })->get();
    }else{
         echo "No destination provided";
    }

score 0 · Answer 4 · answered Feb 12 '18 at 05:47

You need to use destinations variable in your where closure:

if($request->has('destinations'))
{

    $destinations = $request['destinations'];
    $trips = Trip::where('status','=',1)->whereHas('destinations', function($q) use ($destinations){
    $q->where('destinationsid', '=', $destinations);
    })->get();

Undefined variable. Laravel

4 Answers4