UIimage Detect Landscape Image with Swift

Question

I want to read a photo from Library

in this function

 func imagePickerController(_ picker: UIImagePickerController, didFinishPickingMediaWithInfo info: [String : Any]) {
        let pickedImage = info[UIImagePickerControllerOriginalImage] as? UIImage

now I want to know is that landscape photo or not I try to tie this code

if(pickedImage?.size.width > pickedImage?.size.height)

But I received this error Binary operator '>' cannot be applied to two 'CGFloat?' operands how can I resolve this Problem

Shehata Gamal · Accepted Answer · 2018-02-11T19:45:03.743

2

Try this

 if let pickedImage = info[UIImagePickerControllerOriginalImage] as? UIImage

   { 
      if pickedImage.size.width > pickedImage.size.height 
      {
         /// landscape mode
      }

   }

}

edited Feb 11 '18 at 19:45

answered Feb 11 '18 at 13:30

Shehata Gamal

98,760
8
65
87

score 1 · Answer 2 · answered Feb 11 '18 at 13:32

The problem here that you try to work with Optional values, instead of unwrapped. To unwrap value you can use guard:

guard let pickedImage = pickedImage else { 
    // false logic here
    return 
}

if pickedImage.size.height > pickedImage.size.height {

} else {

}

By the way, are you sure that you want to compare pickedImage's height to itself? Looks weird.

score 1 · Answer 3 · answered Feb 11 '18 at 13:43

1

I find the solution with this code ? -> !

if(pickedImage!.size.width > pickedImage!.size.height)

answered Feb 11 '18 at 13:43

Miloo

117
1
2
10

this is bad practice to use force unwrap (? -> !), because your app can crash. – pacification Feb 11 '18 at 13:45
@pacification yep he should avoid ! and use ? – Shehata Gamal Feb 11 '18 at 13:45
@Sh_Khan, no. He should use `if let ...` or `guard let ...` to get result value. – pacification Feb 11 '18 at 13:47
this what I meant by ? sure it's a mirror to if let and guard – Shehata Gamal Feb 11 '18 at 13:48
No, it's not true. – pacification Feb 11 '18 at 13:48

score 0 · Answer 4 · answered Feb 11 '18 at 17:29

0

Another possible solution could be to use switch pattern matching:

switch image?.size {
case .some(let size) where size.height > size.width:
  // do something
default:
  break
}

answered Feb 11 '18 at 17:29

kiwisip

437
1
4
12

UIimage Detect Landscape Image with Swift

4 Answers4