Counting total posts by a user in the blade view

Question

I have sent a collection of all posts in my blog to my index view and then used the following code to count the total posts made by each user.

<p class="joined-text">Posts: {{count(App\Posts::where('user_id', $post->user->id)->get())}}</p>

Is this bad practice to do this from within the blade view? If it is how would I achieve this?

Models

class Posts extends Model
{
    public function user()
    {
        return $this->belongsTo(User::class);
    }

    public function comments()
    {
        return $this->hasMany(Comments::class, 'post_id');
    }
}





class User extends Authenticatable
{

    public function posts()
    {
        return $this->hasMany('\App\Posts::class');
    }

    public function comments()
    {
        return $this->hasMany(Comments::class);
    }
}

Amin Fazlali · Accepted Answer · 2018-02-10T14:03:54.420

4

Simple solution:

<p class="joined-text">Posts: {{ App\Posts::where('user_id', $post->user_id)->count() }}</p>

Updated

Complete and better solution:

Post.php:

public function user(){
    return $this->belongsTo(App\User::class);
}

User.php:

public function posts(){
    return $this->hasMany(App\Post::class);
}
public function getPostsCountAttribute(){
    return $this->posts()->count();
}

blade:

<p class="joined-text">Posts: {{ $post->user->posts_count }}</p>

edited Feb 10 '18 at 14:03

answered Feb 10 '18 at 13:49

Amin Fazlali

1,209
1
9
17

It's bad because you query in view! – Mahdi Younesi Feb 10 '18 at 13:52
@MahdiYounesi Ok. You are right! That was a simple solution only. – Amin Fazlali Feb 10 '18 at 13:59
Thank you . That's what I wanted. I tried to incorporate it into the model as a method but I was struggling. – Finchy70 Feb 10 '18 at 14:11

Mahdi Younesi · Answer 2 · 2018-02-10T13:56:13.003

0

Yes it is bad.

You could use relationships if have the user_id field in posts table

class User extends Model
{
  public function posts()
  {
     return $this->hasMany('App\Post');
  }
}

In controller

return view('sth')->with(['posts'=>$user->posts]);

Then in view

$posts->count();

Or just getting counts if you don't need posts

$postCount = $user->posts()->count();

edited Feb 10 '18 at 13:56

answered Feb 10 '18 at 13:49

Mahdi Younesi

6,889
2
20
51

I have user_id in my post table. Where do I use $user->posts(); – Finchy70 Feb 10 '18 at 13:54

Counting total posts by a user in the blade view

2 Answers2

Linked