Fastest way to create and move backup files to a directory?

Question

I want to create a backup file before performing any operation on the file and then move it a to a location with the folder structure being D:\BACKUP\(Date)\(Time).

What is the fastest way of doing it? I'm currently doing it as below

string path = textBox1.Text;
var files = Directory.GetDirectories(path, "dtpo", SearchOption.AllDirectories)
                     .SelectMany(t => Directory.GetFiles(t, "*.txt")).ToArray();

foreach (var file in files)
{
    File.Copy(file,file+".bk",true);
    string OnlyDate=DateTime.Today.ToString("dd-MM-yyyy");
    string OnlyTime = DateTime.Now.ToString("hh-mm-ss");
    if (!Directory.Exists(@"D:\BACKUP\" + OnlyDate+"\\"+OnlyTime))
    {
        Directory.CreateDirectory(@"D:\BACKUP\" + OnlyDate+"\\"+OnlyTime);
    }

    string rootFolderPath = Path.GetFullPath(file+".bk");
    string targetPath=@"D:\BACKUP\" + OnlyDate+"\\"+OnlyTime+"\\"+Path.GetFileName(file+".bk");
    File.Move(rootFolderPath, targetPath);
    //Do the processes
}

Possible duplicate of [Fastest way to copy files from one directory to another](https://stackoverflow.com/questions/32236796/fastest-way-to-copy-files-from-one-directory-to-another) — TheGeneral, Feb 06 '18 at 02:01

score 1 · Accepted Answer · answered Feb 06 '18 at 02:01

1

Directory.exists can be bypassed, createdirectory won't run if it does. Also recommend you don't do 2 io operations to write the file. Just write directly to the output using file.copy.

answered Feb 06 '18 at 02:01

Ctznkane525

7,297
3
16
40

Can you explain a little? what do you mean by `Just write directly to the output using file.copy.` – Tamal Banerjee Feb 06 '18 at 02:03
The bk file isn't needed... Call system.io.file.copy(file,Target path) – Ctznkane525 Feb 06 '18 at 02:07
Are you talking about removing the line `File.Copy(file,file+".bk",true);` ? – Tamal Banerjee Feb 06 '18 at 02:08
Yes...that's unnecessary...as is the directory exists check – Ctznkane525 Feb 06 '18 at 02:09
Thanks for helping :) – Tamal Banerjee Feb 06 '18 at 02:12

Fastest way to create and move backup files to a directory?

1 Answers1