Keeping a picturebox within the borders of the form

Question

Hi so i'm making this top down shooter using c# in visual studios and for some reason i can't stop the picture box from moving out of the borders, right now what happens is that if i place the picture box on the bottom right hand corner then it works but doesn't work if i place the picture box in the center here's my code:

private void Level_1_of__desolor_KeyDown(object sender, KeyEventArgs e)
    {
        int xpos = CharacterMain.Location.X;
        int ypos = CharacterMain.Location.Y;
        if (e.KeyCode == Keys.A)
        {
            this.CharacterMain.Load(@"../Graphics\Energy L.png");
        }
        else if (e.KeyCode == Keys.D)
        {
            this.CharacterMain.Load(@"../Graphics\Energy R.png");
            CharacterMain.Left += speed;
        }
        else if (e.KeyCode == Keys.W)
        {
            this.CharacterMain.Load(@"../Graphics\Energy F.png");
            CharacterMain.Top -= 10;
        }
        else if (e.KeyCode == Keys.S)
        {
            this.CharacterMain.Load(@"../Graphics\Energy B.png");
            CharacterMain.Top += 10;
        }
        if (xpos > 12 && xpos < 1096 && ypos == 523)
        {
            if (ypos == 523)
            {
                CharacterMain.Top -= 10;
            }
        }
        if (CharacterMain.Location.Y < 523 && CharacterMain.Location.Y > 12)
        {
            if (CharacterMain.Location.X == 12)
            {
                CharacterMain.Left += 10;
            }
        }
        if (CharacterMain.Location.Y < 523 && CharacterMain.Location.Y > 12)
        {
            if (CharacterMain.Location.X == 12)
            {
                CharacterMain.Left += 10;
            }
        }
        if (CharacterMain.Location.X > 12 && CharacterMain.Location.X < 1102)
        {
            if (CharacterMain.Location.Y == 12)
            {
                CharacterMain.Top += 10;
            }
        }
    }

Perhaps you could post a picture of you problem to make it more clear. What have you tried in order to fix it so far? — Eric Hauenstein, Feb 05 '18 at 18:46
i've tried adding a loop is really the only things i just don't understand why its not working — Nadhaniel Joshy, Feb 05 '18 at 18:51

score 0 · Answer 1 · answered Feb 06 '18 at 19:40

I figured it out my logic came out stupid basically what was happening was i was doing the reverse of everything here's the fixed code.

//Border Control
        #region
        if (xpos < 44)
        {
                CharacterMain.Left += 10;
        }
        if (ypos > 523)
        {
            CharacterMain.Top -= 10;
        }
        if (ypos < 89)
        {
            CharacterMain.Top += 10;
        }
        if (xpos > 1068)
        {
            CharacterMain.Left -= 10;
        }
        #endregion

You will see that the numbers are different its simply changed to suit borders that were better suited for my game — Nadhaniel Joshy, Feb 06 '18 at 19:41

Keeping a picturebox within the borders of the form

1 Answers1