How to initialize instance properties?

Question

I have sample code in my Class:

public $themePath = "layouts/inbox/";

public $theme     = $this->themePath."theme-limitless.";

public $inboxView = $this->theme."inbox";

And here my code not work. I must save my theme name in one var and path to theme in another var and use view using theme name. Now I have error:

Constant expression contains invalid operations:

public $theme     = $this->themePath."theme-limitless."; // Error line

Generaly I must get path in var $inboxView:

$inboxView = "layouts/inbox/theme-limitless.inbox";

Probably duplicate of : https://stackoverflow.com/a/40171696/7415107 — André DS, Jan 15 '18 at 09:28
Here is a thought: stop using public visibility for object's attributes. — tereško, Jan 23 '18 at 11:19
Ok, then I'll private or protected object's attributes @tereško — Andreas Hunter, Jan 24 '18 at 07:13

score 1 · Accepted Answer · answered Jan 15 '18 at 09:32

1

You can initializate class properties in __construct method:

class MyClass
{
    public $themePath = "layouts/inbox/";
    public $theme;
    public $inboxView;

    function __construct() {
        $this->theme     = $this->themePath . "theme-limitless.";
        $this->inboxView = $this->theme . "inbox";
    }

}

answered Jan 15 '18 at 09:32

Vladimir

1,373
8
12

1

No. This is wrong. Your code is violating [OCP](https://en.wikipedia.org/wiki/Open/closed_principle). – tereško Jan 23 '18 at 11:10

How to initialize instance properties?

1 Answers1