Copy ResourceStream In Stream

Question

I need help in this code

This is all code

Request: TIdHTTPRequestInfo

Response: TIdHTTPResponseInfo

JQuery: TResourceStream

procedure TServer.ActiveServer;
begin
  DefaultPort := 8117;
  Active := True;
  OnCommandGet := FServerCommandGet;
  JQuery := TResourceStream.Create(HInstance,'JQuery',RT_RCDATA);
end;

function TServer.FindFiles: Boolean;
var
  Stream : TStream;
begin
  if Request.Document = '/jquery.js' then
  begin
    Response.ContentType := 'application/x-javascript';
    Stream := TStream.Create;
    Stream.Position := 0;
    Stream.CopyFrom(JQuery,JQuery.Size);
    Response.ContentStream := Stream;
    Result := True;
  end else
    Result := False;
end;

error : TStream.Seek not implemented

The problem is in the copy TResourceStream in TStream

Request: TIdHTTPRequestInfo; Response: TIdHTTPResponseInfo; JQuery: TResourceStream; — NINO SAN, Jan 11 '18 at 12:09
We cant see how JQuery has been created, please provide full code — whosrdaddy, Jan 11 '18 at 12:10
JQuery := TResourceStream.Create(HInstance,'JQuery',RT_RCDATA); — NINO SAN, Jan 11 '18 at 12:14
Please do not add code in comments but [edit](https://stackoverflow.com/posts/48206083/edit) your question and provide a full code sample that exposes the problem. Since you are new here, please read this link: https://stackoverflow.com/help/mcve — whosrdaddy, Jan 11 '18 at 12:16

score 2 · Answer 1 · edited Jan 11 '18 at 16:14

2

TStream is an abstract class so it cannot be used directly, you must use one it's descendants. TResourceStream for example.

P.S : I see that you are dealing with Indy, no need to free the stream when assigned to ContentStream, Indy will handle that for you.

function TServer.FindFiles: Boolean;
var
  Stream : TResourceStream;
begin
  if Request.Document = '/jquery.js' then
  begin
    Response.ContentType := 'application/x-javascript';
    Response.ContentStream := TResourceStream.Create(HInstance, 'JQuery', RT_RCDATA);
    Result := True;
  end else
  begin
    Result := False;
  end;
end;

edited Jan 11 '18 at 16:14

Remy Lebeau

555,201
31
458
770

answered Jan 11 '18 at 11:45

whosrdaddy

11,720
4
50
99

There's also a [TResourceStream](http://docwiki.embarcadero.com/Libraries/Tokyo/en/System.Classes.TResourceStream) – Stijn Sanders Jan 11 '18 at 12:03
The same problem – NINO SAN Jan 11 '18 at 12:10
JQuery: TResourceStream – NINO SAN Jan 11 '18 at 12:10
JQuery := TResourceStream.Create(HInstance,'JQuery',RT_RCDATA); – NINO SAN Jan 11 '18 at 12:16
I'm not good in English language – NINO SAN Jan 11 '18 at 12:37
The editor asked me to add more details – NINO SAN Jan 11 '18 at 12:37
2

I would even `Response.ContentStream:=TResourceStream.Create(HInstance,'JQuery',RT_RDCATA);` – Stijn Sanders Jan 11 '18 at 12:40
thanks this is the solution – NINO SAN Jan 11 '18 at 12:57
1

@whosrdaddy The code shown in your answer is all wrong. `TResourceStream` does not have a parameterless constructor, and it is read-only, so calling `CopyFrom()` on it is an invalid operation. Change `TResourceStream` to `TMemoryStream` and then the code will be *almost* "correct" (you would need to seek `JQuery.Position` instead of `Stream.Position`), but will not be thread-safe (`JQuery` only has 1 `Position`), as you can't copy `JQuery` in multiple HTTP requests simultaneously without synchronizing access to it. Best to create a new `TResourceStream` on each request, like Stijn showed. – Remy Lebeau Jan 11 '18 at 15:58
@RemyLebeau, yes that is correct, changed accordingly – whosrdaddy Jan 11 '18 at 16:06

Copy ResourceStream In Stream

1 Answers1