setOnItemClickListener does not fire any event

Question

I have a custom List Adapter and I need to start a new Activity when a user clicks in a row in the fragment, but seems that setOnItemClickListener does not work. I have tried adding both Toast and Log, but can't see any text in logcat or any toast on the screen.

What's wrong with my code?

singolo_personaggio.xml (This is the custom row layout)

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:orientation="horizontal"
    android:padding="5dp">

    <LinearLayout
        android:id="@+id/image_container"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:orientation="horizontal"
        android:padding="3dp">

        <ImageView
            android:id="@+id/lista_personaggi_icon"
            android:layout_width="60dp"
            android:layout_height="60dp"
            android:layout_alignParentLeft="true"
            android:src="@drawable/ic_launcher" />
    </LinearLayout>

    <TextView
        android:id="@+id/lista_personaggi_nome"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:layout_alignTop="@+id/image_container"
        android:layout_toRightOf="@+id/image_container"
        android:layout_marginLeft="10dp"
        android:textStyle="bold"
        android:textSize="22dp"
        android:text="Name"
        />

    <TextView
        android:id="@+id/lista_personaggi_ruolo"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:layout_marginLeft="10dp"
        android:layout_toRightOf="@+id/image_container"
        android:layout_below="@+id/lista_personaggi_nome"
        android:textSize="18sp"
        android:text="Role"
        />
</RelativeLayout>

This is the Java code:

public View onCreateView(LayoutInflater inflater, ViewGroup container,
                                 Bundle savedInstanceState) {

            Integer pageToShow = getArguments().getInt(ARG_SECTION_NUMBER);

            View rootView = inflater.inflate(R.layout.fragment_choose_character, container, false);
            ListView listView = (ListView) rootView.findViewById(R.id.listViewPersonaggi);

            personaggiDB = new DatabasePersonaggiHandler(getContext());
            ArrayList<Personaggio> personaggi = personaggiDB.getAllPersonaggi(pageToShow);

            // Adatto il personaggio alla grafica della lista
            this.m_adapter = new PersonaggioAdapter(getContext(), R.layout.riga_personaggio, personaggi);
            listView.setAdapter(this.m_adapter);

            // Su ogni elemento della lista aggiungo il click
            listView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
                @Override
                public void onItemClick(AdapterView<?> parent, View v, int position, long id) {

                    Toast.makeText(getContext(), "show this", Toast.LENGTH_LONG);
                    Log.d("MYAPP -->", "I am here");
                    // Recupero l'intero oggetto cliccato
                    //Personaggio personaggioScelto = m_adapter.getItem(position);

                    //Intent singoloPersonaggioIntent = new Intent(getContext(), SingoloPersonaggioActivity.class);
                    //singoloPersonaggioIntent.putExtra("PersonaggioObj", personaggioScelto);
                    //startActivity(singoloPersonaggioIntent);
                }
            });

            return rootView;
        }

post your parent layout.. i mean the main layout...the layout which the fragment inflates.. — Santanu Sur, Jan 01 '18 at 16:36
you need `Toast.makeText(getContext(), "show this", Toast.LENGTH_LONG).show();` — Pavneet_Singh, Jan 01 '18 at 16:38

score 0 · Accepted Answer · edited Jan 02 '18 at 01:31

0

You have to add

android:focusable="false"

to your clickable elements of singolo_personaggio.xml due to an old Android issue.

Hopefully, this clear the issue.

edited Jan 02 '18 at 01:31

JoxTraex

13,423
6
32
45

answered Jan 01 '18 at 16:38

Dimitar

4,402
4
31
47

Thanks, now I can click on items but my app just restart to each click – Christian Giupponi Jan 01 '18 at 16:46
@ChristianGiupponi Strange, have you resolved it? It is most probably a crash. For the exact cause, you have to investigate the logcat. – Dimitar Jan 01 '18 at 16:53
Yes, I'm trying but each time the logcat clear the output and I can't see where the error is – Christian Giupponi Jan 01 '18 at 16:54
1

If you are using Android Studio, maybe this [SO answer](https://stackoverflow.com/questions/29568985/android-studio-logcat-cleans-after-app-closes/31040015#31040015) might be helpful in that regard. – Dimitar Jan 01 '18 at 16:59
@user8 could you elaborate on what "android issues" you're referring to? what is the actual problem? – JoxTraex Jan 01 '18 at 17:58
1

@user8 I have updated your post to have a reference to that link :) – JoxTraex Jan 02 '18 at 01:31

setOnItemClickListener does not fire any event

1 Answers1