Unit testing a void method with Redis async command in java

Question

I'm trying to write a unit test for the following function.

responseHandler and ErrorHandler are both methods that are passes using the Command Pattern and are used to continue the program's flow. futureCommand is a lettuce object (Redis implementation in java). I'm having difficulties with how to test this method since is both using a future and does not return anything.

public void getOfferData(EventRequestContext<? extends BaseEvent> ctx, int offerId, ResponseHandler<T1Offer> responseHandler,
        ErrorHandler<Throwable> errorHandler) throws Exception {
    String redisKey = keyPrefix + offerId;
    RedisFuture<List<String>> futureCommand = connectionWrapper.getHashValues(redisKey, getRequiredParams());
    futureCommand.thenAccept(valuesList -> {
        TrackerScheduler.processT1GenreicPool.execute(ctx, () -> {
            Map<String, String> resultMap = reconstructMapValues(valuesList, getRequiredParams(), redisKey, ctx);
            T1Offer offerData;
            if(!resultMap.isEmpty()) {
                offerData = new T1Offer(resultMap);
            } else {
                offerData = new T1Offer();
            }
            if(!offerData.isValid()) {
                errorHandler.onError(new Exception("Invalid fields in offerData"));
            } else {
                responseHandler.onResponse(offerData);
            }
        });
    });
}

My best attempt was to send the assertion using the responseHandler method like this:

@Test
public void getOfferData_offerFullData_parseSuccess() throws Exception {
    T1ClickOfferDao.instance.getOfferData(null, Integer.parseInt(OFF_ID), resultOffer -> { 
        Assert.assertEquals("", resultOffer.getActivationDate());
    }, error -> {
    });
}

but the Test context is finished before the future is evaluated. And even if I Threas.sleep for a second - the assertion does not affect the test result.

"does not return anything" have you considered making it return the future? — Andy Turner, Dec 28 '17 at 10:30
Returning the future will pass the logic in "thenAccept()" to the calling method, same problem different place. — gshlomig, Dec 28 '17 at 12:14
Ok, so... Return the result of `futureCommand.thenAccept(...).toCompleteableFuture()`? — Andy Turner, Dec 28 '17 at 12:57

score 0 · Answer 1 · answered Apr 19 '18 at 06:36

0

How about

@Test
public void getOfferData_offerFullData_parseSuccess() throws Exception {
    final String lock = new String("lock");
    T1ClickOfferDao.instance.getOfferData(null, Integer.parseInt(OFF_ID), resultOffer -> { 
        Assert.assertEquals("", resultOffer.getActivationDate());
        synchronized(lock){
            lock.notifyAll();
        }
    }, error -> {
    });
    synchronized(lock){
        try{ 
            lock.wait(1000*2); 
        } catch (InterruptedException ex) {
            fail("Timeout");
        }
    }
}

answered Apr 19 '18 at 06:36

Imaskar

2,773
24
35

Did you have any success with it? – Imaskar May 18 '18 at 11:35
Yes, eventually did something like the example above with locking and it works well. seems to be the only way. – gshlomig Aug 23 '18 at 13:38

Unit testing a void method with Redis async command in java

1 Answers1