str_replace() not working with while loop with variable for search argument

Question

$query1 = mysqli_query($cone,"SELECT words FROM banlist ORDER BY words") or die(mysql_error());

while($row = mysqli_fetch_array($query1, MYSQLI_ASSOC)) {
    $fix = (string)$row['words'];                   
    $title = str_replace($fix, "-", $title);
}

echo $title;

var_dump($row)'s output:

array(1) {
    ["words"]=> string(5) "hello "
}
array(1) {
    ["words"]=> string(5) "you "
}

It doesn't replace any string in the title But if I put the values directly like "hello" in the place of $fix then it works fine.

this is what output of var_dump($row) inside the while `array(1) { ["words"]=> string(5) "hello" } array(1) { ["words"]=> string(5) "you " }` — Ashish Choudhary, Dec 25 '17 at 21:11
it is defined as `$title = $_POST['title']` in the beginning of the page. — Ashish Choudhary, Dec 25 '17 at 21:15
so you want to replace hello and you with - in title. what is initial title and do you get in the end — JoshKisb, Dec 25 '17 at 21:18
`var_dump($title)` gives the `string(25) "this is a hello world page for you"` — Ashish Choudhary, Dec 25 '17 at 21:18
@JoshKisb Yes Indeed. If i use `$fix` then it gives the same output as the `$title` but if i use a string directly like `"hello"` then it does replaces. — Ashish Choudhary, Dec 25 '17 at 21:21
What is the value of $row['words'] when you dump that in the loop? — Simon R, Dec 25 '17 at 21:24
Yes I realise that but what values e.g. is it returning a string, and if it is, is the value one already in your title? — Simon R, Dec 25 '17 at 21:26
@SimonR This is the ouput `string(5) "hello " string(5) "you "` I think its the space coming after every value how can i include data from a file to mysql by trimming it — Ashish Choudhary, Dec 25 '17 at 21:31
Small observation: You actually print `mysql_error()` instead of `mysqli_error()`; — Gerrit Luimstra, Dec 25 '17 at 23:59
@GerritLuimstra Actually it worked by removing the space from the values but thankyou for telling me this — Ashish Choudhary, Dec 26 '17 at 22:12

score 0 · Accepted Answer · edited Dec 25 '17 at 23:59

Through some troubleshooting with you, we ascertained that it was the space coming from the database field. To correct the issue code should be changed to

$query1 = mysqli_query($cone,"SELECT words FROM banlist ORDER BY words") or die(mysql_error());

while($row = mysqli_fetch_array($query1, MYSQLI_ASSOC)) {
    $fix = trim($row['words']);                   
    $title = str_replace($fix, "-", $title);
}

echo $title;

Ideally strings should be trimmed as they get inserted to the database to prevent this issue.

str_replace() not working with while loop with variable for search argument

1 Answers1