Entity Framework deleting object upon Update

Question

I have a problem where Entity Framework (Core) is deleting an object upon update. I think this is related to Automapper (map DTO Resource to object). I have other objects mapped the exact same way as this object and updates work just fine.

public async Task<IActionResult> UpdateFeedback(Guid Id, [FromBody] FeedbackResource feedbackResource)
{
    if (!ModelState.IsValid)
        return BadRequest(ModelState);
    //removing or else get a tracking error with EF
    feedbackResource.FeedbackType = null;
    var feedback = await feedbackRepository.GetFeedback(Id);

    if (feedback == null)
        return NotFound();

    //if I use this line to map, EF will delete the object upon save.  

    mapper.Map<FeedbackResource, Feedback>(feedbackResource, feedback);

    // if I map manually, i get no error
    //feedback.Title = feedbackResource.Title;
    //feedback.Details = feedbackResource.Details;
    //feedback.IsGoodFeedback = feedbackResource.IsGoodFeedback;
    //feedback.IsReviewed = feedbackResource.IsReviewed;
    //feedback.FeedbackTypeId = feedbackResource.FeedbackTypeId;

    //if(feedbackResource.IsReviewed){
    //    feedback.ReviewDate = DateTime.Now;
    //    feedback.ReviewedBy = UserId;
    //} else {
    //    feedback.ReviewDate = null;
    //    feedback.ReviewedBy = null;
    //}

    await uow.CompleteAsync();

    return Accepted(feedback); 
}

I have no idea what to troubleshoot here and cannot see this issue on any google search.

You should start by adding a breakpoint to your code so that you can examine the result of the mapping operation and to ensure that all the properties of the FeedbackResource are bound and present as expected. — Mike Brind, Dec 06 '17 at 09:40
For me, this issue ended up being caused by an interaction between the automapper and EntityFramework. This was described well by https://stackoverflow.com/questions/32120042/automapper-creating-new-instance-rather-than-map-properties — Ben W, Jun 18 '21 at 00:15

Сергей Рыбаков · Answer 1 · 2018-01-23T11:39:52.000

I was faced with a similar situation (ef core 1.1). I will assume that your problem is similar to mine.

Also a similar problem is described here

I have the following models:

1) ApplicatonUser - standard user from EF

2) AnyDAL - any class in DB, which have link to user

 public class AnyDAL
 {
    public long Id { get; set; }

    public long UserId { get; set; }
    public ApplicationUser User { get; set; }
}

3) AnyDTO - model that comes from the browser side. Like your's [FromBody] FeedbackResource feedbackResource

public class AnyDTO
{
    public long Id { get; set; }

    public long UserId { get; set; }

    /// It is root of all evil. See below.
    /// And yes, it is bad practice.
    public ApplicationUser User { get; set; }
}

Scenario:

1) get AnyDAL from the database;

2) map AnyDTO on AnyDAL using AutoMapper _mapper.Map(DTO, DAL);

3) SaveChanges()

In one case, SaveChanges() leads to Delete, in other to Update.

What we should know: in my case property AnyDTO.User is always null after deserialization.

The choice between delete and update depends on the value of property AnyDAL.User before mapping:

1)AnyDAL.User is null - we get Update.

2)AnyDAL.User is NOT null - we get Delete.

In other words. If property AnyDAL.User changed from some value to null - entity will be deleted. Despite the fact that AnyDAL.UserId remains the same.

There is two ways to solve it:

1) Remove property User from AnyDTO;

2) Property AnyDTO.User should always has value.

I described my solution to a similar problem and indicated what exactly the problem was. — Сергей Рыбаков, Jan 23 '18 at 11:29
Yes, at first I wanted to comment but I can't do it because newbie. — Сергей Рыбаков, Jan 23 '18 at 11:41
Thanks, I had the same problem as describe in the question and your answer helped me resolve it. — wlf, Mar 03 '20 at 10:10
I can't thank you enough! this solution worked for me I had the same issue — DaminiVyas, Nov 24 '20 at 19:40

score 0 · Answer 2 · edited Sep 22 '19 at 10:20

This is a little old but I ran into the same issue with EF Core 2.2 and based on this EntityFrameworkCore it is still an issue in 3.0

The issue seems to be that the navigation property being null is causing the entity to be deleted.

I was able to resolve by configuring lazy loading

Install this package

Microsoft.EntityFrameworkCore.Proxies

Enable lazy loading in the configuration

protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
    optionsBuilder.UseLazyLoadingProxies();

score 0 · Answer 3 · answered Feb 09 '23 at 16:57

for me, this was resolved if I marked as Detached the entity, use automapper to map, then mark entity as Modified.

        _context.Entry(product).State = EntityState.Detached;

        _mapper.Map<ProductVM, Product>(viewModelProduct, product);

        _context.Entry(product).State = EntityState.Modified;

        _context.SaveChanges();

score -1 · Answer 4 · answered May 31 '23 at 10:29

-1

Entity framework needs to know if you want to update or delete. You need to solve this by giving the EntityState before SaveChanges():

dbContext.Entry(yourUpdatingEntity).State = EntityState.Modified;
dbcontect.SaveChages();

answered May 31 '23 at 10:29

Sadjad Khazaie

2,102
22
22

Entity Framework deleting object upon Update

4 Answers4