Bourbon accordion click once expand/collapse when clicked

Question

Hello I'm new here and I wondered if anyone could help. I have implemented bourbon.io's accordion, but I can not get it to open and collapse on a single click.

It opens, but then stays open.

$('.js-accordion-trigger').bind('click', function(e){
  jQuery(this).parent().find('.submenu').slideToggle('fast');  // apply the toggle to the ul
  jQuery(this).parent().toggleClass('is-expanded');
  e.preventDefault();
});

JSFiddle Demo

When another section is clicked then the one that's opened will collapse. At the minute it stays opened. — Antony Moss, Dec 02 '17 at 20:44

Muhammad Omer Aslam · Accepted Answer · 2017-12-02T21:43:17.620

0

See below if that is what you wanted

$('.js-accordion-trigger').on('click', function(e) {
  $('ul.submenu').not($(this).parent().find('ul.submenu')).slideUp('fast');
  $(this).parent().find('.submenu').toggleClass('is-expanded').slideToggle('fast');
  e.preventDefault();
});

ul.submenu {
  display: none;
}

.is-expanded {
  display: block;
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<ul class="accordion">
  <li>
    <a href="javascript:void(0)" class="js-accordion-trigger">Accordion Item</a>
    <ul class="submenu">
      <li>
        <a href="javascript:void(0)">Sub Item 1</a>
      </li>
      <li>
        <a href="javascript:void(0)">Sub Item 2</a>
      </li>
    </ul>
  </li>
  <li>
    <a href="javascript:void(0)" class="js-accordion-trigger">Another Item</a>
    <ul class="submenu">
      <li>
        <a href="javascript:void(0)">Sub Item 1</a>
      </li>
      <li>
        <a href="javascript:void(0)">Sub Item 2</a>
      </li>
    </ul>
  </li>
</ul>

edited Dec 02 '17 at 21:43

answered Dec 02 '17 at 20:58

Muhammad Omer Aslam

22,976
9
42
68

Is there a parenthesis missing from line two? I cant get it to work. – Antony Moss Dec 02 '17 at 21:15
sorry that was a typo while removing `console.log` statement check code now @AntonyMoss just updated the answer – Muhammad Omer Aslam Dec 02 '17 at 21:17
No I wanted the effect in this example https://codepen.io/danhearn/pen/vWXzvm?limit=all&page=2&q=accordion+js – Antony Moss Dec 02 '17 at 21:24
Apologies as I am a new developer. – Antony Moss Dec 02 '17 at 21:26
i cant find any difference other than we are using `slideToggle` and the code you provided uses class to show/hide, do you want it not to `slide` but simply `show` and `hide` without slide efffect? – Muhammad Omer Aslam Dec 02 '17 at 21:26
If you notice in the codepen example, only one section is displayed at any one time. The version you have done displays all sections until you click again. – Antony Moss Dec 02 '17 at 21:31
check now @AntonyMoss just updated the snippet, i still used the `slide` effect you can swap it with any effect you wan t – Muhammad Omer Aslam Dec 02 '17 at 21:43
– absolute genius, that's exactly how I wanted it. Thank you. Ive update the JSFiddle – Antony Moss Dec 02 '17 at 21:48
glad that i could help you out , do select the answer as correct so other can benefit too having same problem – Muhammad Omer Aslam Dec 02 '17 at 21:49

Bourbon accordion click once expand/collapse when clicked

1 Answers1