10

We use FxCop's global suppressions to suppress rule violations found in old code. By old code I mean code that was written sometimes years before we turned on code analysis. We fix violations in new code. We cannot fix the violations in the old code all at once so we use suppressions.

Over time our global suppression files have become bloated. Often when a signature has changed on an old method the prior suppression becomes invalid because it no longer matches up with the code. We created new suppressions to ignore the old violation but often the old SuppressMessage attributes were left behind.

Does anybody know how to identify these SupressMessage declarations that do not match up with code? For that matter does anybody know how to identify SuppressMessage attributes that are invalid because there is no violation to supress?

I am thinking there may be a compiler or FxCopCmd warning or log message that might identify unused suppressions. If not that does anybody know of a script or VS extension that does it?

Thanks.

Dan Finucane
  • 1,547
  • 2
  • 18
  • 27
  • I hope you plan on eventually removing all of these suppressions. I find that they clutter up code if used too much. – Bernard Jan 18 '11 at 19:40
  • @Bernard - The global suppressions are not within your class files, so you won't see them unless you go look for them. The pain is when you try to find the one you want to remove or alter. – Pedro Jan 18 '11 at 22:51
  • @Pedro: You are correct. But you can also suppress warnings at the method level, which I wouldn't recommend doing. – Bernard Jan 19 '11 at 14:28

1 Answers1

2

You can use the stand-alone FxCop UI application for this. Add the "Seen Last Run" column to the "Excluded In Source" results tab. After analysis, this column will show a false value for any in-source suppressions for which a corresponding violation was not found during the analysis run. In order to maximize the reliability of the results, you should ensure that you are using the same set of rule assemblies for the analysis that you use when running the analysis from Visual Studio.

BTW, if you would like to be able to break your build when "stale" suppressions are found, you might want to consider voting at https://connect.microsoft.com/visualstudio/feedback/details/277253/add-mechanism-for-detecting-unnecessary-suppressmessageattribute-instances.

Nicole Calinoiu
  • 20,843
  • 2
  • 44
  • 49