data duplication in tableview cell when scrolling

Question

Im getting json data from the backend , and displaying them in the tableview. each object is displayed in a cell, some objects have same names, other have different.

the problem is when I am scrolling the tableview, the object names are changing. My code in cellForRow atIndex path:

static NSString *cellIdentifier = @"cell2";
ProccessingOrderTableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:cellIdentifier forIndexPath:indexPath];
Order *order = self.orderArray[indexPath.row];
NSString *role = [NSUserDefaults.standardUserDefaults objectForKey:@"userRole"];
if([role isEqualToString:@"brand.operator"]){
    cell.branchName.hidden = NO;
    NSString *roleDisplay = [NSString stringWithFormat:@"%@%@", @"Branch name: " ,order.branch.name ] ;
    cell.branchName.text = roleDisplay;
} else if([role isEqualToString:@"corporate.operator"]){
    cell.branchName.hidden = NO;
    NSString *roleDisplay = [NSString stringWithFormat:@"%@%@ \n%@%@", @"Branch name: " , order.branch.name,@"Brand name: ",order.branch.brand.name ] ;
    cell.branchName.text = roleDisplay;
} else {
    cell.branchName.hidden = YES;
}

the field "cell.branchName.text" is changing on scrolling,

Any idea whats happening?

what is the correlation between those names you mention above the code for `cellForRow` and the `cell.branchName.text`? — Milan Nosáľ, Nov 10 '17 at 07:22
cell.branchName.text is the name of the label, where I want to display the text received, which is in "order.branch.name", cellfoRow, is just the tableview method — , Nov 10 '17 at 07:25
I was asking about `firstObject.name = @"MyName";` - how does this go with the rest of the question? — Milan Nosáľ, Nov 10 '17 at 07:27
you can use cell that cell is reusable so that problem arrise — Sagar Bhut, Nov 10 '17 at 07:30
this is an example, just forget it, I was explaining what I am doing — , Nov 10 '17 at 07:30
Try creating `ProccessingOrderTableViewCell` with an initializer - if the problem disappears, then the problem is really in reusing cells — Milan Nosáľ, Nov 10 '17 at 07:34
Unrelated to the issue but retrieving the (same value of ) `userRole` from user defaults in each call of `cellForRow` is unnecessarily expensive. — vadian, Nov 10 '17 at 07:35
how do I create ProccessingOrderTableViewCell with an initializer? — , Nov 10 '17 at 07:37
@Ali.Jab can you give a gif for your problem? It's easier for use to find solution. — trungduc, Nov 10 '17 at 08:58
the problem is just that data is changing in tableViewCell when scrolling the table view — , Nov 10 '17 at 13:00

score 0 · Answer 1 · answered Nov 10 '17 at 07:47

0

Cell gets reused when you scroll in UITableView and UICollectionView. Hence you see the old text for fraction of second and gets updated to proper value.

Use prepareForReuse of UITableViewCell method to clear the textFields before reuse to avoid such issues

In your ProccessingOrderTableViewCell write

-(void) prepareForReuse {
    [super prepareForReuse];
    //clear your textfields here
    self.branchName.text = @"";
   //clear/reset other UI components as well
}

answered Nov 10 '17 at 07:47

Sandeep Bhandari

19,999
5
45
78

As you see in his question, he handle every case to update `self.branchName` in `cellForRowAtIndexPath` so `prepareForReuse` in this case is useless. – trungduc Nov 10 '17 at 08:59
so whats the solution? @ trungduc – Nov 10 '17 at 12:59

data duplication in tableview cell when scrolling

1 Answers1