PLS-00394: Wrong number of values in the INTO list of a fetch statement

Question

This is my attempt in creating a cursor in a stored procedure

   --Second Stored Procedure--
 CREATE OR REPLACE PROCEDURE sp_GetDiscountedRate (DiscountCode IN    
VARCHAR2,Percentage IN NUMBER, ReserveDate IN DATE)
 IS  --Code declaration section--
--variables to store column values returned from select into
 pPassengerID            VARCHAR2(10);
 pFirst                  VARCHAR2(20);
 pMiddle                 VARCHAR2(20);
 pLast                   VARCHAR2(20);
 pPassengerType          CHAR (1);
 uUSMilitaryID           VARCHAR (8);
 uMilitaryBranch         VARCHAR2 (20);
 uMilitaryDiscountCode   VARCHAR2(8);
 rFlightNumber           VARCHAR2(6);
 rReservationCost        NUMBER(6);
 rReservationDate        DATE;
 --Declare Cursor
            CURSOR cur_USMilitary IS
            --Query cursor will point to results 
  SELECT P.PassengerID, P.First, P.Middle, P.Last, P.PassengerType,    
  U.USMilitaryID, U.MilitaryBranch,   
  U.MilitaryDiscountCode, R.FlightNumber, R.ReservationCost,   
  R.ReservationDate,
  CASE U.MilitaryDiscountCode WHEN DiscountCode THEN   
  Percentage*R.ReservationCost 
  ELSE R.ReservationCost END "REVISED_RESERVATION_COST"
  FROM PASSENGER P, US_Military U, RESERVATION R
  WHERE P.PassengerID = U.MPassengerID
  AND P.PassengerID = R.PassengerID
  AND U.MilitaryDiscountCode = DiscountCode
  AND R.ReservationDate = ReserveDate;

       --Start Execution section--
BEGIN 
      --Open Cursor
     OPEN cur_USMilitary; --  open cursor for use   
     --loop to display each record returned by cursor 
     --Use PL/SQL language control or loop to display each record pointed by cursor 
    LOOP
        --Fetch cursor data
        FETCH cur_USMilitary INTO pPassengerID,  
       pFirst,pMiddle,pLast,pPassengerType,

uUSMilitaryID,uMilitaryBranch,uMilitaryDiscountCode,rFlightNumber,
rReservationCost,rReservationDate;
        EXIT WHEN cur_USMilitary%NOTFOUND;
        --Display each record
        --Displaying the results
DBMS_OUTPUT.PUT_LINE ('CUSTOMER INFORMATION: ');
DBMS_OUTPUT.PUT_LINE ('The PassengerID is:  ' ||pPassengerID);
DBMS_OUTPUT.PUT_LINE ('First Name of passenger is:  ' ||pFirst);
DBMS_OUTPUT.PUT_LINE ('Middle Name of passenger is:  ' ||pMiddle);
DBMS_OUTPUT.PUT_LINE ('Last Name of passenger is:  ' ||pLast);
DBMS_OUTPUT.PUT_LINE ('Passenger Type of customer is: ' ||pPassengerType);
DBMS_OUTPUT.PUT_LINE ('US Military ID of Passenger is:  ' ||uUSMilitaryID);
DBMS_OUTPUT.PUT_LINE ('Military Branch of passenger is:  ' ||uMilitaryBranch);
DBMS_OUTPUT.PUT_LINE ('Military Discount code of passenger is:  ' ||uMilitaryDiscountCode);
DBMS_OUTPUT.PUT_LINE ('Flight number of passenger is:  ' ||rFlightNumber);
DBMS_OUTPUT.PUT_LINE ('Reservation Cost of passenger is:  ' ||rReservationCost);
DBMS_OUTPUT.PUT_LINE ('Reservation Date of passenger is:  ' ||rReservationDate);

END LOOP; 



    CLOSE cur_USMilitary; --close cursor

 END sp_GetDiscountedRate;

I get this error:

Error(36,9): PL/SQL: SQL Statement ignored
Error(36,9): PLS-00394: wrong number of values in the INTO list of a FETCH statement

I fully understand the error. I checked the number of columns and it looks like to me that they match the number of columns within the query. I've also checked the datatypes to make sure it was correct.

score 3 · Answer 1 · answered Nov 04 '17 at 22:33

You have

12 columns in your cursor's SELECT part

but

11 columns in FETCH statement part

, i observe

CASE U.MilitaryDiscountCode WHEN DiscountCode THEN   
  Percentage*R.ReservationCost 
  ELSE R.ReservationCost END "REVISED_RESERVATION_COST"

part is missing in FETCH( or should be omitted in the SELECT part ).

It also represents a column, and it spoils 1-1 correspondence, which yields that error.

score 1 · Answer 2 · answered Nov 04 '17 at 22:51

This is what happens when you overcomplicate things, I'm afraid. I don't see any need for all those variables and the corresponding fetch into that is hard to keep in sync. Why not just:

create or replace procedure sp_getdiscountedrate
    ( discountcode in varchar2
    , percentage   in number
    , reservedate  in date )
is
begin
    for r in (
        select p.passengerid
             , p.first
             , p.middle
             , p.last
             , p.passengertype
             , u.usmilitaryid
             , u.militarybranch
             , u.militarydiscountcode
             , r.flightnumber
             , r.reservationcost
             , r.reservationdate
             , case u.militarydiscountcode
                   when discountcode then percentage * r.reservationcost
                   else r.reservationcost
               end as revised_reservation_cost
        from   passenger p
               join us_military u
                    on   u.mpassengerid = p.passengerid
               join reservation r
                    on   r.passengerid = p.passengerid
                    and  r.discountcode = u.militarydiscountcode
                    and  r.reservedate = r.reservationdate
    )
    loop
        dbms_output.put_line('CUSTOMER INFORMATION:');
        dbms_output.put_line('The PassengerID is:  ' || r.passengerid);
        dbms_output.put_line('First Name of passenger is:  ' || r.first);
        dbms_output.put_line('Middle Name of passenger is:  ' || r.middle);
        dbms_output.put_line('Last Name of passenger is:  ' || r.last);
        dbms_output.put_line('Passenger Type of customer is: ' || r.passengertype);
        dbms_output.put_line('US Military ID of Passenger is:  ' || r.usmilitaryid);
        dbms_output.put_line('Military Branch of passenger is:  ' || r.militarybranch);
        dbms_output.put_line('Military Discount code of passenger is:  ' || r.militarydiscountcode);
        dbms_output.put_line('Flight number of passenger is:  ' || r.flightnumber);
        dbms_output.put_line('Reservation Cost of passenger is:  ' || r.reservationcost);
        dbms_output.put_line('Reservation Date of passenger is:  ' || r.reservationdate);
        dbms_output.put_line('Revised reservation cost is:  ' || r.revised_reservation_cost);
    end loop;

end sp_getdiscountedrate;

(Untested)

Gordon Linoff · Answer 3 · 2017-11-04T22:57:11.767

0

You go through all the trouble of calculating "REVISED_RESERVATION_COST", and then you don't read it from the cursor.

No wonder Oracle is complaining. You need a variable for this column as well.

I would also advise you to learn to use modern, proper, explicit JOIN syntax.

edited Nov 04 '17 at 22:57

answered Nov 04 '17 at 22:28

Gordon Linoff

1,242,037
58
646
786

It’s a requirement for my query. Is there another way of calculating within the store procedure? – Fathy Kaid Nov 04 '17 at 22:35
1

@FathyKaid try to place a variable also for `revised_parameter_cost` then. – Barbaros Özhan Nov 04 '17 at 22:38

PLS-00394: Wrong number of values in the INTO list of a fetch statement

3 Answers3

Linked