Ios show/hide views inside a tableview cell

Question

I have a tableview with a custom cell. Below image shows the view hierarchy of my tableview cell.

When adding rows to the tableview I'm hiding the 'check Image' imageview using below code.

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "accountCell", for: indexPath) as! AccountsTableViewCell

            cell.checkImage.isHidden = true

        return cell
    }

and when a row is clicked I'm showing the imageview again. Below is the code

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

        let cell = tableView.dequeueReusableCell(withIdentifier: "accountCell", for: indexPath) as! AccountsTableViewCell

        cell.checkImage.isHidden = false
    }

But the problem is when I click a row nothing happens. system execute the cell.checkImage.isHidden = false code line, but the imageview doesn't appear. It is still hidden. Could someone tell me what I'm doing wrong here?

You can't dod it like that. You need to update the checked/unchecked status somewhere (I suggest using a `Set`) and then check that in your `cellForRowAt` - In `didSelectRowAt` you toggle the checked/unchecked status in your `Set` and then reload the affected cell. — Paulw11, Nov 01 '17 at 04:36
@nazmulHasan after the 'cell.checkImage.isHidden = false' line — udi, Nov 01 '17 at 04:43

Paulw11 · Accepted Answer · 2017-11-01T05:23:32.820

4

You can't track cell checked status in your cell itself; the cell object is just a view onto your data and cells will be reused when the table view scrolls.

I suggest using a Set<IndexPath>. In your cellForRowAt you can check the contents of the set in order to determine whether the checkmark should be hidden:

var checked = Set<IndexPath>()

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
    let cell = tableView.dequeueReusableCell(withIdentifier: "accountCell", for: indexPath) as! AccountsTableViewCell

    cell.checkImage.isHidden = self.checked.contains(indexPath)

    return cell
}

in your didSelectRowAt you simply toggle the set membership and reload the row

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

    if self.checked.contains(indexPath) {
        self.checked.remove(indexPath) 
     } else {
        self.checked.insert(indexPath)
     }

    tableView.reloadRows(at:[indexPath], with:.fade)
}

edited Nov 01 '17 at 05:23

answered Nov 01 '17 at 05:01

Paulw11

108,386
14
159
186

'self.checked.contains(indexPath) ? self.checked.remove(indexPath) : self.checked.insert(indexPath)' gives a compilation error for me. – udi Nov 01 '17 at 05:11
@udi what is your swift version ? – Nazmul Hasan Nov 01 '17 at 05:16
@NazmulHasan swift 4 – udi Nov 01 '17 at 05:17
Compilation error is: Result values in '? :' expression have mismatching types 'IndexPath?' and '(inserted: Bool, memberAfterInsert: IndexPath)' – udi Nov 01 '17 at 05:19
Sorry. Fixed that – Paulw11 Nov 01 '17 at 05:24

score 3 · Answer 2 · answered Nov 01 '17 at 04:42

3

You have to manage your array (datasource)! when you click your row, update your array for that index and reload your table view.

Example :

Your array should have some flag like isChecked toggle it's value from true to false or vice-versa.

In your cellForRowAtIndexPath check this flag and show or hide your image according to that flag!

answered Nov 01 '17 at 04:42

Ketan Parmar

27,092
9
50
75

2

your solution also working. Unfortunately I can accept only one answer. But thanks for your support. – udi Nov 01 '17 at 05:33

score -1 · Answer 3 · answered Nov 01 '17 at 05:05

first be sure your

 tableview.delegate = self

second thing in did select row at index use that code

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

    let cell = tableView.cellForRow(at: indexPath) as! AccountsTableViewCell


    cell.checkImage.isHidden = false
}

Ios show/hide views inside a tableview cell

3 Answers3

Linked