Recycler view item colour change repeating after scrolling

Question

Recycler view item color change repeating after scrolling.

I used to change color at a particular position of the Recyclerview list. When scrolling occurs another item at the bottom has the same change. And it is repeating in pattern. How to resolve this?

 holder.recycle_Listing.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            itemListener.connectionClicked(v,position, itemtype);

            holder.mainlayout.setBackgroundColor(Color.parseColor("#e927a4d1"));

        }
    });

you can try https://stackoverflow.com/questions/40692214/changing-background-color-of-selected-item-in-recyclerview — Android Surya, Oct 25 '17 at 11:23
please provide more code from your adapter, as for your after scrolling it changes color, ofcourse it is the view is recreated with the same position as the position that you clicked. — Achmad Naufal Syafiq, Oct 25 '17 at 11:29
yes, i found solution for that @AchmadNaufalSyafiq . Thanks for the response. — SARATH V, Oct 26 '17 at 07:54
@AndroidSurya the link was helpful to find answer but not the proper one for me. Thanks — SARATH V, Oct 26 '17 at 07:54

Sharath kumar · Answer 1 · 2017-10-25T12:54:13.307

The recycler view recycles the view in OnBindViewHolder.So when items are clicked it gets reflected in some other positions.To solve this. create a global SparseBooleanArray to store the clicked position.

private final SparseBooleanArray array=new SparseBooleanArray();

Then inside final viewholder add the clickListener and onClick store the position of the clicked item.

public class ViewHolder extends RecyclerView.ViewHolder {
    public YOURVIEW view;
    public ViewHolder(View v) {
        super(v);
        view = (YOURVIEW) v.findViewById(R.id.YOURVIEWID);
        view.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                array.put(getAdapterPosition(),true);
                notifyDataSetChanged();
            }
        });
    }
}

And in inside OnBindViewHolder,

@Override
public void onBindViewHolder(final ViewHolder holder, final int position) {
    if(array.get(position)){
        holder.mainlayout.setBackgroundColor(Color.parseColor("#e927a4d1"));
    }else{
        holder.mainlayout.setBackgroundColor(UNSELECTEDCOLOR);
    }
}

Maybe many items can be clicked so only `mItemSelected ` is not enough. — CoXier, Oct 25 '17 at 12:48

CoXier · Answer 2 · 2017-10-25T12:46:32.267

1

I think you can set your background color in void onBindViewHolder(VH holder, int position); such as

List<Integer> selectedPosition = new ArrayList(yourDataSize);
void onBindViewHolder(VH holder, int position){

     if(selectedPosition.get(position) == 1){
       holder.mainlayout.setBackgroundColor(Color.parseColor("#e927a4d1"));
     }else {
       holder.mainlayout.setBackgroundColor(normalColor);
     }

     //when the item clicked 
     selectedPosition.add(position,1);

}

edited Oct 25 '17 at 12:46

answered Oct 25 '17 at 11:27

CoXier

2,523
8
33
60

what is Data class? – SARATH V Oct 25 '17 at 12:36
found solution and posted here. Thanks – SARATH V Oct 26 '17 at 07:56

Ankur Mishra · Answer 3 · 2017-10-25T11:36:00.063

0

That function returns relative position not absolute so when screen is scrolled position is replaced with a new value. use position from your list for the desired result.

edited Oct 25 '17 at 11:36

answered Oct 25 '17 at 11:28

Ankur Mishra

103
9

score 0 · Answer 4 · answered Oct 25 '17 at 11:36

0

It is due to recycling of viewholder of recycler view. Try this It worked for me.

public ListViewHolder(View itemView) {
        super(itemView);

        this.setIsRecyclable(false);


    }

answered Oct 25 '17 at 11:36

user3856376

75
9

I do not think it's a good idea because recycler view is used for caching. – CoXier Oct 25 '17 at 11:39
disabled the purpose of recycler with this code?. It is not an acceptable method. – SARATH V Oct 25 '17 at 11:47

score 0 · Answer 5 · answered Oct 25 '17 at 12:16

0

try to implement this method in your adapter class, may be it's solve your problem

@Override
    public void onViewRecycled(ViewHolderProduct holder) {
        super.onViewRecycled(holder);
        holder.mainlayout.removeAllViews();
}

answered Oct 25 '17 at 12:16

Munir

2,548
1
11
20

score 0 · Accepted Answer · answered Oct 26 '17 at 07:50

Just saved every item keys in an array and that selected array also passed through my Adapter class. Even simple colour change works fine in this format. Here the code is changed as per my the requirement.

@Override
    public void onBindViewHolder(final ICConversationHomeAddConnectionsAdapter.ViewHolder holder, final int position) {

        JsonObject object = dataArray.get(position).getAsJsonObject();
        if(selectedArray.contains(object.get("userkey").getAsString()))
        {
            GradientDrawable borCol = new GradientDrawable();
            borCol.setCornerRadius(7);
            borCol.setColor(Color.parseColor("#ffffff"));
            borCol.setStroke(2, Color.parseColor("#60B9E1"));
            holder.recycle_Listing.setBackgroundDrawable(borCol);
           //holder.mainlayout.setBackgroundColor(Color.parseColor("#e927a4d1"));
        }
        else
        {
            GradientDrawable borCol = new GradientDrawable();
            borCol.setCornerRadius(7);
            borCol.setColor(Color.parseColor("#ffffff"));
            borCol.setStroke(1, Color.parseColor("#e0e0e0"));
            holder.recycle_Listing.setBackgroundDrawable(borCol);
          //holder.mainlayout.setBackgroundColor(Color.parseColor("#f1f1f1"));
        }


            holder.profileName.setText(object.get("name").getAsString());

        holder.recycle_Listing.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {


                holder.mainlayout.setSelected(!holder.mainlayout.isSelected());

                if (holder.mainlayout.isSelected()) {
                    GradientDrawable borCol = new GradientDrawable();
                    borCol.setCornerRadius(7);
                    borCol.setColor(Color.parseColor("#ffffff"));
                    borCol.setStroke(2, Color.parseColor("#60B9E1"));
                    holder.recycle_Listing.setBackgroundDrawable(borCol);
                  //  holder.mainlayout.setBackgroundColor(Color.parseColor("#11B5DA"));
                } else {
                    GradientDrawable borCol = new GradientDrawable();
                    borCol.setCornerRadius(7);
                    borCol.setColor(Color.parseColor("#ffffff"));
                    borCol.setStroke(1, Color.parseColor("#e0e0e0"));
                    holder.recycle_Listing.setBackgroundDrawable(borCol);
                   // holder.mainlayout.setBackgroundColor(Color.parseColor("#f1f1f1"));
                }



                itemListener.connectionClicked(v,position, itemtype);


               //holder.mainlayout.setBackgroundColor(Color.parseColor("#11B5DA"));
              //holder.mainlayout.setBackgroundColor(Color.parseColor("#f1f1f1"));
            }
        });



    }

This code works fine with no repeated colour change in recycler. If any queries feel free to ask via comments or chat

Young Lee · Answer 7 · 2022-05-13T12:42:25.070

Recyclerview & Room Database in Kotlin.

in Activity: //to send position to Adapter

val putPosition = 5   // what you want to be position
Handler(Looper.getMainLooper()).postDelayed({
       (Recyclerview.layoutManager as LinearLayoutManager).scrollToPositionWithOffset(putPosition-1,0)
}, 1500)
//
//
// out of onCreate (for companion)
fun getVersePosition() = putPosition

in Adapter: // to get position from Activity

override fun onBindViewHolder(holder: Adapter.Holder, position: Int) {
    val roomData = listData[position]
    holder.setRoomData(roomData)
    val activity : MainActivity.Companion = MainActivity
    val getPosition : Int? = activity.companionMainActivity?.getVersePosition()
    if (position == getPosition-1){
            holder.itemView.setBackgroundColor(Color.parseColor("#AFB42B"))
        } else {
            holder.itemView.setBackgroundColor(Color.TRANSPARENT)
        }
}

SparseBooleanArray() doesn't need and bind doesn't need too.

But it's very important

holder.itemView.setBackgroundColor(Color.TRANSPARENT)

If omitted, repetition will occur.

Recycler view item colour change repeating after scrolling

7 Answers7

Linked