Toggle button is not working when checking again

Question

This code is not working after one time. After clicking it once it stops the music but after clicking it again it is not starting the music again.

ToggleButton sound;
MediaPlayer sip;
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);
    sound = (ToggleButton) findViewById(R.id.Sound1);
    sip = MediaPlayer.create(Naruto.this, R.raw.sip2);
    sip.start();
    sound.setOnClickListener(new View.OnClickListener() {
        public void onClick(View arg0) {
            if (sound.isChecked() == true) {
                sip.start();
            } else {
                sip.start();
            }
        }
    });
}

check this one https://stackoverflow.com/questions/21277490/example-on-togglebutton — Mattia Gecchele, Oct 24 '17 at 09:58
please update the answer ti this if (sound.isChecked()){ sip.start(); }else { sip.start(); } — impathuri, Oct 24 '17 at 10:07

score 0 · Answer 1 · answered Oct 24 '17 at 09:59

Try below code;

     sound.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
                Boolean switchState = holder.simpleSwitch.isChecked();

                if (switchState==true)
                {
                   sip.start();
                }
                else
                {
                   sip.stop();
                }
            }
        });

score 0 · Answer 2 · answered Oct 24 '17 at 10:03

0

The MediaPlayer needs to be configured. Try this:

sound.setOnClickListener(new View.OnClickListener(){
    public void onClick(View arg0) {
        if (sound.isChecked()==(true)){
            sip.setDataSource(filePath);
            sip.prepare();
            sip.start();
        }else
        {
            sip.release();
            sip = null;
        }

}});

answered Oct 24 '17 at 10:03

Laur89

105
7

1

`sip.setDataSource(filePath);` generate null pointer exception when toggle button clicked again because you initialize `sip = null` in else part – Vishal Yadav Oct 24 '17 at 10:26
yes, you have to replace `filePath` with your file path. Try to replace that line with `sip = MediaPlayer.create(Naruto.this, R.raw.sip2);` . Please tell me if it works – Laur89 Oct 24 '17 at 10:37

score 0 · Answer 3 · answered Oct 24 '17 at 10:20

You can try this.

sound.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() 
{
    @Override
    public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) 
    {
        if(isChecked)
        {
            sip.start();
        }
        else
        {
            sip.stop();
        }
    }
});

Toggle button is not working when checking again

3 Answers3