newOutputStream Close file

Question

I write to file some text after check by XmlParser. All work fine, but code, don't close that file, then i have problem latter in program with it. It create .tmp file. How close my file after that action ?

def path = new File("my/path"))
def xml = new XmlParser().parse(path)
        xml.appendNode("include", [
                myAppendToCheck"
        ])
        XmlUtil.serialize(xml, path.newOutputStream())            

    path.newOutputStream().flush()
    path.newOutputStream().close()

score 2 · Accepted Answer · answered Oct 13 '17 at 08:01

2

The problem here is that you create 3 different output streams. Just store the stream in a variable:

def stream = path.newOutputStream()
XmlUtil.serialize(xml, stream)
stream.close()

Note also that flush is not necessary before the stream is closed.

answered Oct 13 '17 at 08:01

Henry

42,982
7
68
84

1

That's very helpful, i'm still newbie in java. Thanks :) – John Doe Oct 13 '17 at 09:14

score 0 · Answer 2 · answered Oct 13 '17 at 13:53

Just use withOutputStream

def path = new File("my/path"))
def xml = new XmlParser().parse(path)

xml.appendNode("include", [
    myAppendToCheck"
])

path.withOutputStream { os ->
    XmlUtil.serialize(xml, os)            
}

That will close the stream for you when the closure finishes...

i'm still newbie in java

And this is Groovy, not Java ;-)

newOutputStream Close file

2 Answers2