8

I use Spring boot 1.5.7.
I have not configured CommonsMultipartResolver, because Spring Boot handles file uploads already.

If my upload exceeds the maximum permited size, an ugly Exception is thrown.
This is handled by my controller.

@ControllerAdvice
public abstract class DefaultController implements InitializingBean {
    @ExceptionHandler(Exception.class)
    public ResponseEntity<ServiceException> handleException(final Exception ex) {
        ...
        } else if (ex instanceof MultipartException) {
            MultipartException me = (MultipartException) ex;
            Throwable cause = ex.getCause();
            if (cause instanceof IllegalStateException) {
                Throwable cause2 = cause.getCause();
                if (cause2 instanceof SizeLimitExceededException) {
                    // this is tomcat specific
                    SizeLimitExceededException slee = (SizeLimitExceededException) cause2;
                }
            }
        }

This kind of handling is not only complex but also sadly Tomcat specific, because the SizeLimitExceededException is in the package org.apache.tomcat.util.http.fileupload.FileUploadBase.

How can I handle the error case, that some one uploads a bigger file then allowed and return a nice message, regardless which Servlet Engine is used?

Nabor
  • 1,661
  • 3
  • 20
  • 45

2 Answers2

6

You could define a exception handler method in your @ControllerAdvice which is specifically for MultipartException and then qualify it with a specific HttpStatus. For example:

@ExceptionHandler(MultipartException.class)
@ResponseStatus(value = HttpStatus.PAYLOAD_TOO_LARGE)
public ResponseEntity<ServiceException> handleMultipartException(MultipartException ex) {
    ...
}

This should allow you to focus on the 'maximum file size' exception without having to get into servlet container specifics.

Update 1 in response to this comment:

Sounds good, what about getPermittedSize and getActualSize provided by SizeLimitExceededException is there a chance to get this values not only if Tomcat is used?

By intercepting this error on the basis of (a) the exception type and (b) the HTTP status ... you are making the solution generally applicable. But in so doing you might lose the sort of detailed information that one servlet container (but perhaps not another) might give you. You could perhaps enforce your own maximum size by setting spring.http.multipart.max-file-size in which case you would be able to report 'permitted size' but if you want to report 'actual size' then you'll have to consider one of the following:

  • Have to use something provided by the servlet container
  • Choose a spring.http.multipart.max-file-size which is less thatn the supported maximum for your servlet container and then apply your own max size check inside your controller and throw your own specific exception type containing the actual and permitted sizes.
glytching
  • 44,936
  • 9
  • 114
  • 120
  • Sounds good, what about getPermittedSize and getActualSize provided by SizeLimitExceededException is there a chance to get this values not only if Tomcat is used? – Nabor Oct 12 '17 at 12:05
  • @Nabor: I have updated the answer to address your last comment – glytching Oct 12 '17 at 12:13
  • I will continue to use the current Tomcat specific solution, but the answer is good. – Nabor Oct 13 '17 at 07:06
  • Thanks for this answer... I had an @ExceptionHandler configured and it wasn't working and the exception was still leaking. Turns out the solution was to make it return `ResponseEntity` as in your answer :) – hughjdavey Dec 06 '18 at 10:53
  • Don't know if this worked for you first try but I had to stick an @ControllerAdvice on it to get it working. – Krusty the Clown May 07 '22 at 04:15
2

This working fine in my @RestControllerAdvice and the exception is more specific than MultipartException :

@ExceptionHandler(MaxUploadSizeExceededException.class)
@ResponseStatus(value = HttpStatus.PAYLOAD_TOO_LARGE)
public ResponseEntity handleMultipartException(MaxUploadSizeExceededException e) {

    Map<String, String> result = new HashMap<>();
    result.put("message", "Error ==> Large File ");
    return  ResponseEntity.status(HttpStatus.PAYLOAD_TOO_LARGE)
            .body(result);

}

PS : when using @RestControllerAdvice(annotations = RestController.class) it doens't work .. you have to put @RestControllerAdvice without RestController.class annotation

Saad Joudi
  • 595
  • 4
  • 5