OnClickListener event not working in linear layout

Question

I have LinearLayouts acting as a listView I want to add onClickListener on the rows of the list. The code is inside a fragment.

    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

    for (int i = 0; i < promos.size(); i++) {
        View rowView = inflater.inflate(R.layout.list_item, lv, false);
        holder = new NewsHolder();
        news = (News) promos.get(i);
        holder.title = (TextView) rowView.findViewById(R.id.title);
        holder.title.setText(news.title);
        holder.excerpt.setText(news.excerpt);
        lv.addView(rowView);
        rowView.setOnClickListener(new View.OnClickListener() {

            @Override
            public void onClick(View v) {
                Toast.makeText(getActivity(),"clicked item"+news.id,Toast.LENGTH_LONG).show();
            }
        });

    }
    mainL.addView(linear);
    return mainL;
}

Do you have something else inside the row `View` besides the `TextView`? Post the `list_item` layout. — Mike M., Oct 10 '17 at 10:45
Yes it contains image view and another text view.I didn't show all of it for simplicity. Thanks I found it I forgot to add android:clickable="true" for the main layout. — Mark Samy, Oct 10 '17 at 10:49
Can you edit the latest code after the comment mention by @Mike M. — Burhanuddin Rashid, Oct 10 '17 at 10:54
lv.addView(rowView); add this line after setting the click listner — Burhanuddin Rashid, Oct 10 '17 at 10:56
Solved I forgot to add android:clickable="true" to the list_item.xml. — Mark Samy, Oct 10 '17 at 11:06

score 0 · Answer 1 · answered Oct 10 '17 at 10:54

You need to add the rowView inside your Linearlayout after defining onclicklistner like this,

public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

for (int i = 0; i < promos.size(); i++) {
    View rowView = inflater.inflate(R.layout.list_item, lv, false);
    holder = new NewsHolder();
    news = (News) promos.get(i);
    holder.title = (TextView) rowView.findViewById(R.id.title);
    holder.title.setText(news.title);
    holder.excerpt.setText(news.excerpt);

    rowView.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
            Toast.makeText(getActivity(),"clicked item"+news.id,Toast.LENGTH_LONG).show();
        }
    });
    lv.addView(rowView);

}
mainL.addView(linear);
return mainL;
}

Solved I forgot to add android:clickable="true" to the list_item.xml — Mark Samy, Oct 10 '17 at 11:06

score 0 · Answer 2 · answered Oct 10 '17 at 11:00

0

Added android:clickable="true" to the list_item.xml.

answered Oct 10 '17 at 11:00

Mark Samy

148
10

score -4 · Answer 3 · answered Oct 10 '17 at 10:44

-4

Looks like you searching for solution like in this topic. Read here ListView with OnItemClickListener android

answered Oct 10 '17 at 10:44

Mykhailo Voloshyn

596
2
11

I don't use ListView. – Mark Samy Oct 10 '17 at 10:58

OnClickListener event not working in linear layout

3 Answers3