Artisan Call in Loop

Question

I have a custom console command that needs to loop through some companies and make a database for each. The command works now, but only once. It does not run the migration the second time around in the loop. So basically if I have 2 blank DBs (db_one and db_two) the config runs and migrates the first time for db_one and when the loop runs again, nothing happens to db_two. If I replace the console command to just echo out the DB name it returns both so I know its not the loop. Also if I log out the db used in each connection of the loop, its the correct DB.

Here is the command:

public function handle()
{
    $companies = Company::all();

    foreach( $companies as $company)
    {
        \Config::set('database.connections.company.database', $company->db_name);

        Artisan::call( 'migrate', [
            '--database' => 'company',
            '--path' => 'database/migrations/company',
        ]);

        $this->info(  config('database.connections.company.database') );

    }
}

log error:

local.ERROR: Database [10_barrel] not configured. {"userId":1,"email":"packy@sites.com","exception":"[object] (InvalidArgumentException(code: 0): Database [db_2] not configured. at /Users/Sites/cheers/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:140)

database.php

'connections' => [

        'main' => [
            'driver' => 'mysql',
            'host' => env('MAIN_DB_HOST', '127.0.0.1'),
            'port' => env('MAIN_DB_PORT', '3306'),
            'database' => env('MAIN_DB_DATABASE', 'forge'),
            'username' => env('MAIN_DB_USERNAME', 'forge'),
            'password' => env('MAIN_DB_PASSWORD', ''),
            'unix_socket' => env('MAIN_DB_SOCKET', ''),
            'charset' => 'utf8mb4',
            'collation' => 'utf8mb4_unicode_ci',
            'prefix' => '',
            'strict' => true,
            'engine' => null,
        ],

        'company' => [
            'driver' => 'mysql',
            'host' => env('COMPANY_DB_HOST', '127.0.0.1'),
            'port' => env('COMPANY_DB_PORT', '3306'),
            'database' => '',
            'username' => env('COMPANY_DB_USERNAME'),
            'password' => env('COMPANY_DB_PASSWORD'),
            'unix_socket' => env('COMPANY_DB_SOCKET', ''),
            'charset' => 'utf8mb4',
            'collation' => 'utf8mb4_unicode_ci',
            'prefix' => '',
            'strict' => true,
            'engine' => null,
        ],
]

env:

COMPANY_DB_HOST=127.0.0.1
COMPANY_DB_PORT=3306
COMPANY_DB_USERNAME=root
COMPANY_DB_PASSWORD=

@Webdesigner I added the top error I saw in the log (not the whole stack trace) — Packy, Oct 07 '17 at 17:44
And this Error is a direct result of your command? What Larael version do you have? — Webdesigner, Oct 07 '17 at 17:46
@Webdesigner Sorry, I found the correct error and changed the question. So it would seem the `\Config::set('database.connections.company.database', $company->db_name);` doesnt get set the second time — Packy, Oct 07 '17 at 17:53
@Packy the `\Config:: set` is only temporary and for the current request/command. It will not affect the actual artisan command that is being called as that will re-read the original config. — apokryfos, Oct 07 '17 at 18:06
@apokryfos Why would it work for the first time in the loop and not the second though? — Packy, Oct 07 '17 at 18:17
The first might coincide with the actual existing defaults of the configuration. How does the underlying command set the configuration? — apokryfos, Oct 07 '17 at 18:22
Hmmm I added my env config, there is no default DB to use for the Company connection. — Packy, Oct 07 '17 at 18:25
@Packy Are you sure you are showing us exact code of command. Are you using supervisor for running this command? — Marcin Nabiałek, Oct 07 '17 at 18:47
@MarcinNabiałek yes this is the exact code. And I just run it in terminal — Packy, Oct 07 '17 at 18:49

Webdesigner · Answer 1 · 2017-10-07T18:23:22.127

I assume that you have some problem with your logic. You set a DB name to your configuration but dose this DB exit? And what about the rest? User, Password? Are they always the same?

The Loop is not the problem, right! $companies = Company::all(); Will get get the date from the default database, and you can loop.

I assume the first DB in your list exist already (mayby the default one), but the second on not, and migrate do not create a database it only fills it with data, if laravel can connect to th DB.

score 0 · Accepted Answer · answered Oct 07 '17 at 19:23

It was quite interesting. I need to say I wasn't able to fully reproduce your error (I didn't get any error in log) but for sure migration is run only for 1st loop iteration.

First thing instead of:

Artisan::call

I would recommend you to use:

$this->call

you will get extra output what is really going.

But the most important thing to make it work is to disconnect from database and purging the connection. Otherwise Laravel won't see that you changed your database name in configuration and will use old database.

So you should add:

$this->laravel['db']->purge('company');

at the end of loop to make it possible to run migrations like this.

I've tested it and it's working for me without any problem.

Perfect. I had a feeling I had to purge the connection. Good work. — Packy, Oct 08 '17 at 22:44

Artisan Call in Loop

2 Answers2