Does JsonReader in gson need to be explicitly closed

Question

I want to do this with gson when reading from a json file:

JsonReader reader = new JsonReader(new InputStreamReader(
                new FileInputStream(filename)));
JsonParser jsonParser = new JsonParser();
return jsonParser.parse(reader).getAsJsonObject();

I'll do more things with the returned JsonObject somewhere else.

My question is that whether this is okay since I never close the reader.

From the gson API of JsonReader, it shows that JsonReader implements AutoClosable. Does that mean JsonReader will be automatically closed? If so, when is it closed and how?

Thank you.

https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html — shmosel, Oct 02 '17 at 23:06

score 2 · Accepted Answer · edited Oct 03 '17 at 07:49

2

Yes, you have to close your reader. As shmosel points out AutoClosable can be used for try-with-resource statements which were introduced in Java 7.

Here is how you could adjust your code:

try(JsonReader reader = new JsonReader(new InputStreamReader(
    new FileInputStream(filename))))
{
  JsonParser jsonParser = new JsonParser();
  return jsonParser.parse(reader).getAsJsonObject();
}

edited Oct 03 '17 at 07:49

shmosel

49,289
6
73
138

answered Oct 02 '17 at 23:18

PaL

136
2
10

Does JsonReader in gson need to be explicitly closed

1 Answers1