getting string from resource strings.xml

Question

When I get the string from the strings.xml , I don't get an error right away, but I can't run the program :

String myButtonText = getString(R.string.ButtonText);

(when I remove this line and this variable from my program it works perfectly)

I'll put up my program, in case you'd need it:

public class MainActivity extends AppCompatActivity {

    private Button button;
    String myButtonText = getString(R.string.ButtonText);

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        button = (Button) findViewById(R.id.button);

        button.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

           if(myButtonText.equals("Red")){//the button's text is "red" already
               button.setText("Blue");
           }
            }//I'm changing the text on the button to "blue" when it says"red"
        });
    }
}

remove the attribution from the top of the class and do this inside the onCreate method: `myButtonText = getResources().getString(R.string.ButtonText)` — joao86, Sep 14 '17 at 00:42

score 1 · Answer 1 · answered Sep 14 '17 at 00:42

1

You are doing:

String myButtonText = getString(R.string.ButtonText);

I think you have to retrieve value from strings.xml inside onCreate() method:

String myButtonText = getResources().getString(R.string.ButtonText);

answered Sep 14 '17 at 00:42

Satan Pandeya

3,747
4
27
53

No still doesnt run – amirsoltani Sep 14 '17 at 01:05
Are you sure you have text in `strings.xml`. – Satan Pandeya Sep 14 '17 at 01:08
100% sure even the color of ButtonText changes – amirsoltani Sep 14 '17 at 01:10
Put that thing inside `onCreate` method. – Satan Pandeya Sep 14 '17 at 01:31

score 1 · Accepted Answer · answered Sep 14 '17 at 00:44

1

You should call getString(...) within the activity lifecycle to ensure that all the components under the hood are initialized.

In your example, you should call myButtonText = getString(R.string.ButtonText); in onCreate(...)

answered Sep 14 '17 at 00:44

Jon

1,715
12
14

Thank you that worked i did String myButtonText; then myButtonText in oncreat() – amirsoltani Sep 14 '17 at 01:14

getting string from resource strings.xml

2 Answers2