-1

I'm new to developing with Meteor and node-based apps. I intend to create a PR for a problem i noticed in Rocket.Chat.

I git cloned the Rocket.Chat dev branch and made a change to a certain file: https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-oembed/client/oembedImageWidget.html

After that i ran the build-script successfully. My build started, but the change is not included. Using the Chrome Dev Tools to inspect the change, i still see the original unchanged code.

I know it's a rather generic question and i'm sure the solution is kind of stupid, but any idea why ?

Thank you. Kind regards

johnyb0y
  • 1
  • 1
  • I'm voting to close this question as off-topic because this is a question for the maintainers of this software and users of SO cannot do anything about it. – Rob Sep 30 '17 at 03:26

2 Answers2

1

It looks like the file you modified is in the packages directory. This is dealt with differently.

Check the .meteor/packages files to see if this package is referenced, if it is, then it will install the package from the atmosphere package management system.

Here the steps required to make your changes work...

1) Edit the .meteor/packages file and change the reference to rocketchat:oembed to be simply oembed

2) Edit the file packages/rocketchat-oembed/package.js and do the same thing, change rocketchat:oembed to be simply oembed

Package.describe({
    name: 'oembed',
    version: '0.0.1',
    summary: 'Message pre-processor that insert oEmbed widget in template',
    git: ''
});

I think you can leave the directory names as is.

Meteor will now use your local package instead of going out to get the published version of it

Mikkel
  • 7,693
  • 3
  • 17
  • 31
  • Yes it is! Thanks. It's listed as rocketchat:oembed. – johnyb0y Sep 06 '17 at 11:32
  • Thanks for your answer. To me it looks like it's already a local package. At least i can't find it here: https://atmospherejs.com. i want to minimize the changes i make to the branch, since my fix is really small. – johnyb0y Sep 06 '17 at 12:07
  • EDIT: Also, as soon as i change the package-name, several dependencies will break. Any way to find out, if this package is really a published package ? – johnyb0y Sep 06 '17 at 12:16
0

In addition to @Mikkel's answer: I think you don't have to change package name, but just change its version. That should be enough for Meteor to rebuild this package from its source and you won't have any dependency issues.

Styx
  • 9,863
  • 8
  • 43
  • 53
  • Thanks! Already tried that. I was able to verify that Meteor rebuilt the package. Sadly my changes still didn't carry over to the build. But i think i'm doing something else wrong. If i find a solution to my specific problem, i will post it here. – johnyb0y Sep 07 '17 at 12:45