Loop in Script not working

Question

I'm trying to redirect a user after a onclick action but the userid in the following code always remains the same regarless the user chosen in the table. Maybe I'm missing something here...

<td>
  <?php if ($memberinfo['UserIsChecked'] == 1){ ?>
    <button class="btn btn-xs btn-icon btn-default"> <i class="fa fa-times"></i> </button>
  <?php } else { ?>
    <a href="#"><p onclick="go()">Approve/Refuse <?php echo($memberinfo['UserId']) ;?></p></a>
    <script>
      var userid='<?php echo $userid;?>';
      function go(){
        swal({
          title: 'Are you sure?',
          text: "You won't be able to revert this!",
          type: 'warning',
          showCancelButton: true,
          confirmButtonText: 'Validate user',
          cancelButtonText: 'Refuse request',
          confirmButtonClass: 'btn btn-success',
          cancelButtonClass: 'btn btn-danger m-l-10',
          buttonsStyling: false
        }).then(function () {
          swal(
            'User validated!',
            'The user has been notified.',
            'success',
          ).then(function(){
            window.location = 'scripts/process-validate-user.php?userid='+ userid +' ' ;
          })
        }, function (dismiss) {
          // dismiss can be 'cancel', 'overlay',
          // 'close', and 'timer'
          if (dismiss === 'cancel') {
            swal(
              'User refused',
              'The user has been notified.',
              'error'
            )
          }
        })
      }
    </script>
  <?php } ?>
</td>

And which part should actually change the `userid`? Where does `$userid` come from? What loop are you talking about? — Sebastian Simon, Sep 04 '17 at 20:52

score 0 · Answer 1 · answered Sep 04 '17 at 20:54

0

are you iterating over columns or rows in that table? if so then you are probably redeclaring and reinitializing userid as well as the go() function itself in global scope.

try adding an x-userid="" attribute to anchor tags where you bind go() function. Then in the go function would start as follows:

function go(event) { var userid = event.target.getAttribute('x-userid'); ... }

answered Sep 04 '17 at 20:54

Marcin Malinowski

766
5
13

`data-userid`, not `x-userid`. – Sebastian Simon Sep 04 '17 at 20:55

score 0 · Answer 2 · edited Sep 04 '17 at 21:06

0

if those are table rows, then you can simply add a hidden <div> as in after <tr> as below:

<td>
<?php if ($memberinfo['UserIsChecked'] == 1){ ?>
    <button class="btn btn-xs btn-icon btn-default"> <i class="fa fa-times"></i> </button>
<?php } else { ?>
    <span style="display:none" class="user-id"><?php echo($memberinfo['UserId']) ;?></span>
    <a href="#"><p onclick="go()">Approve/Refuse <?php echo($memberinfo['UserId']) ;?></p></a>

Then, in the JavaScript code, get this <span> text by JavaScript or jQuery relative to the user’s click.

edited Sep 04 '17 at 21:06

Sebastian Simon

18,263
7
55
75

answered Sep 04 '17 at 21:01

Bassem Shahin

656
7
13

I tried this but instead of giving me the first entry it's giving me the last one of my table rows – jmouk Sep 04 '17 at 21:34
you will write all ids in the table rows using PHP in a hidden `
` or `` and then will get the value by JavaScript or jQuery relative to the user’s click. As below: `$(this).find(".user-id").text()`
– Bassem Shahin Sep 04 '17 at 22:04

Loop in Script not working

2 Answers2