Javascript standardjs - how to fix 'is already defined'?

Question

What is the better to fix this 'error' of 'is already defined'?

function findOneAndUpdate (find) {
    var find = find || {}
     ...
}

The test from standardjs:

$ standard

... 'find' is already defined.

Any suggestions?

score 1 · Answer 1 · answered Sep 01 '17 at 11:47

1

You need to leave out the var, because the variable find is already declared through the method header:

function findOneAndUpdate (find) {
    find = find || {};
    ...
}

answered Sep 01 '17 at 11:47

Peter B

GMaiolo · Accepted Answer · 2017-09-01T17:36:40.330

1

ES6+ solution with default parameters:

function findOneAndUpdate(find={}) { ... }

ES5- would be renaming:

function findOneAndUpdate (_find) { 
  var find = _find || {} 
  ... 
}

Otherwise, you can completely replace the variable, like other answers suggest:

function findOneAndUpdate (find) { 
  find = find || {} 
  ... 
}

edited Sep 01 '17 at 17:36

answered Sep 01 '17 at 11:50

GMaiolo

love this solution! – Run Sep 01 '17 at 11:51
but isn't `function findOneAndUpdate(find={}) { ... }`? – Run Sep 01 '17 at 11:52
1

@teelou yes, missed a parenthesis – GMaiolo Sep 01 '17 at 11:55
thanks for the edit! :-) – Run Sep 01 '17 at 17:33

score 0 · Answer 3 · answered Sep 01 '17 at 11:45

Why not just change either the function parameter name or the new variable's name? The variable name find is clashing with the parameter find.

If all you want is give it an empty object as default parameter, you can safely reuse the parameter:

find = find || {}, just remove the var.

3 Answers3