c++ check if the integer is in the array

Question

I need help. I have an assignment that says:

Asks the user to type 10 integers of an array and an integer v. The program must search if v is in the array of 10 integers. The program writes "v is in the array" if the integer v is in the array or "v is not in the array" if it's not.

My code seems fine, but it does not work properly. Please help.

Here's my code:

#include <iostream>
#include <conio.h>
#include <stdlib.h>
using namespace std;

int main () {
    const int size = 10;
    int vars[size],temp = 0,v = 0;
    int boolean = 0,choice;
    string check = "";
    for(int x = 0; x<10; x++){
        cout<<"Enter 10 Numbers: ";
        cin>>vars[x];
    }

    do{
        cout<<"Enter V variable :";
        cin>>v;

        for(int x = 0; x <10; x++)
        {
            temp = vars[x];
            if(temp == v){
                check = "v is in the array";
            }
            else{
                check  = "v is not in the array";
            }
        }
        cout<<check;
        cout<<"\nContinue ?"<<endl<<"[1]yes"<<endl<<"[2]no"<<endl;
        cin>>choice;
        system("cls");
        for(int x = 0; x<10;x++){
            cout<<"index" <<x<<" = "<<vars[x]<<endl;
        }
    } while(choice != 2);
    return 0;
}

Welcome to Stack Overflow! It sounds like you may need to learn how to use a debugger to step through your code. With a good debugger, you can execute your program line by line and see where it is deviating from what you expect. This is an essential tool if you are going to do any programming. Further reading: [How to debug small programs](http://ericlippert.com/2014/03/05/how-to-debug-small-programs/) — NathanOliver, Aug 22 '17 at 19:46
and https://stackoverflow.com/questions/2069367/how-to-debug-using-gdb — Yunnosch, Aug 22 '17 at 19:47
Also when asking a question it makes sense to describe what your application is actually doing and how it deviates from the expected behavior (this form of applied therapy is often a very good step towards actually solving the issue yourself). — amo-ej1, Aug 22 '17 at 19:56

WhozCraig · Answer 1 · 2017-08-22T22:01:47.063

The lack of any IO error checking notwithstanding, you should be establishing your messaging check value based on completed iteration, not based on each iteration.

This:

    for(int x = 0; x <10; x++)
    {
        temp = vars[x];
        if(temp == v){
            check = "v is in the array";
        }
        else{
            check  = "v is not in the array";
        }
    }

    cout << check;

will execute the loop iteration size times no matter what, resetting check with each iteration and only printing the last iteration results. What you want is something like this:

    int x = 0;
    for(; x <size && vars[x] != v; ++x);

    if (x == size)
        std::cout << v << " is NOT in the array";
    else
        std::cout << v << " is in the array";

Or better still, use the standard library and stop reinventing the wheel:

    auto it = std::find(std::begin(vars), std::end(vars), v);
    if (it == std::end(vars))
        std::cout << v << " is NOT in the array";
    else
        std::cout << v << " is in the array";

score 0 · Answer 2 · answered Aug 22 '17 at 19:50

You are running the loop 10 times. Even if the first number is the answer you are looking for, the second iteration of the loop will rewrite your "check" variable.

Either break on the if in order to exit the loop or change your logic.

You look like a beginner, so refer to this to read more about break statements.

score 0 · Answer 3 · answered Aug 22 '17 at 20:02

Your program is correct except the most important thing is in your loop when the condition succeeds meaning the number V is found you must break n order not to be changed the next iteration. So as quickly as it is found don't continue iterating over all the elements of the array break.

for(int x = 0; x <10; x++){
    if(vars[x] == v){
        check = "v is in the array";
        break;// You must add break to get out of the loop with `check = "v is in the array"`.
    }
    else{
            check  = "v is not in the array";
        }
    }

Thanks for all of your help guys. I just really forgot to break. I need a break :) — arteezy, Aug 22 '17 at 20:05

c++ check if the integer is in the array

3 Answers3