Spring mvc error while extending generic controller

Question

I have a generic base controller. And a list of controllers extending that generic controller. I has seen some examples, where its possible to extend controllers. But I am getting Caused by: java.lang.IllegalStateException: Ambiguous mapping error.

Base Controller:

public abstract class BaseController<O extends BaseDomain, OT extends BaseDto> {

    private AbstractService<O, OT> service;

    public BaseController(AbstractService<O, OT> service) {
        this.service = service;
    }

    @RequestMapping(value="/", method = RequestMethod.GET)
    public ResponseObject list() {
        return somework();
    }

    @RequestMapping(value = "/{id}", method = RequestMethod.GET)
    public ResponseObject get(@PathParam("id") String id) {
        return somework();
    }

    @RequestMapping(value="/", method = RequestMethod.POST)
    public ResponseObject create(@Valid @RequestBody OT input, Errors errors) {
        return somework();
    }

    @RequestMapping(value = "/{id}", method = RequestMethod.PATCH)
    public ResponseObject update(@PathParam("id") String id, @Valid @RequestBody OT input, Errors errors) {
        return somework();
    }

    @RequestMapping(value = "/{id}", method = RequestMethod.DELETE)
    public ResponseObject delete(@PathParam("id") String id) {
        return somework();
    }

}

Child Controller 1:

@RestController("/apis")
public class ApiController extends BaseController<Api, ApiDto>{

    public ApiController(@Autowired ApiService apiService) {
        super(apiService);
    }
}

Child Controller 2:

@RestController("/clusters")
public class ClusterController extends BaseController<Cluster, ClusterDto>{

    public ClusterController(@Autowired ClusterService clusterService) {
        super(clusterService);
    }
}

Error:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping': Invocation of init method failed; nested exception is java.lang.IllegalStateException: Ambiguous mapping. Cannot map '/clusters' method 
public com.casa.authorizebase.dto.ResponseObject com.casa.authorize.controller.BaseController.get(java.lang.String)
to {[/{id}],methods=[GET]}: There is already '/apis' bean method
public com.casa.authorizebase.dto.ResponseObject com.casa.authorize.controller.BaseController.get(java.lang.String) mapped.
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1628)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483)
    at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
    at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:867)
    at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
    at org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
    at org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:325)
    at org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:107)
    at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4633)
    at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5095)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1425)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1415)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
    at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
    at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:941)
    at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:839)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1425)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1415)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
    at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
    at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:941)
    at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:258)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
    at org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
    at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:770)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
    at org.apache.catalina.startup.Catalina.start(Catalina.java:657)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:355)
    at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:495)
Caused by: java.lang.IllegalStateException: Ambiguous mapping. Cannot map '/clusters' method 
public com.casa.authorizebase.dto.ResponseObject com.casa.authorize.controller.BaseController.get(java.lang.String)
to {[/{id}],methods=[GET]}: There is already '/apis' bean method
public com.casa.authorizebase.dto.ResponseObject com.casa.authorize.controller.BaseController.get(java.lang.String) mapped.
    at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping$MappingRegistry.assertUniqueMethodMapping(AbstractHandlerMethodMapping.java:576)
    at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping$MappingRegistry.register(AbstractHandlerMethodMapping.java:540)
    at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.registerHandlerMethod(AbstractHandlerMethodMapping.java:264)
    at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.detectHandlerMethods(AbstractHandlerMethodMapping.java:250)
    at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.initHandlerMethods(AbstractHandlerMethodMapping.java:214)
    at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.afterPropertiesSet(AbstractHandlerMethodMapping.java:184)
    at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping.afterPropertiesSet(RequestMappingHandlerMapping.java:127)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1687)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1624)
    ... 42 more

I am using spring 4.3.10.RELEASE. Any help how to fix? Thanks.

are you sure you posted everything? Since it looks like you have a double mapping of /apis — Ognjen Mišić, Aug 10 '17 at 06:40
@OgnjenMišić Thanks for reply. Yes, I had posted everything — Deepak Agrawal, Aug 10 '17 at 06:42
@DeepakAgrawal Try "@RestController" RequestMapping (value= "/clusters") — mohit sharma, Aug 10 '17 at 06:49

score 2 · Accepted Answer · answered Aug 10 '17 at 06:59

2

You can try with:

@RestController
@RequestMapping("/apis")

and

@RestController
@RequestMapping("/cluster")

answered Aug 10 '17 at 06:59

NikNik

2,191
2
15
34

score 1 · Answer 2 · answered Aug 10 '17 at 07:06

1

You have mapping like this in both child controllers:

    @RestController
    RequestMapping (value= "/clusters")

answered Aug 10 '17 at 07:06

mohit sharma

1,050
10
20

score 0 · Answer 3 · answered Aug 10 '17 at 07:24

0

The value passed to @RestController, defines the logical name for that bean in Spring application context which is by default the camelCase version of that class name. @RequestMapping could be used to specify url mapping on classes as well.

answered Aug 10 '17 at 07:24

Nima AJ

1
1

Spring mvc error while extending generic controller

3 Answers3