API Delete not updating DB

Question

So I have this request in my API which is called by a fetch request run on a button press:

router.delete('/itemDelete/:id', function(req, res, next){
  User.findOne({_id: req.params.id}).then(function(user){
    var userTemp = user;
    var items = user.items;
    var i = 0;
    for(i=0; i<items.length; i++){
      if(items._id == req.body.itemID){
        items.splice(i,1);
      }
    }
    userTemp.items = items;
    User.findByIdAndUpdate(req.params.id, userTemp, function(err, user){
      res.send(user);
    });
  }).catch((err) => console.error(err));
});

The code runs and there is no errors but the database does not change.

score 1 · Answer 1 · answered Aug 05 '17 at 16:14

1

Make sure this block is not error. There is no error checking, whether err is null or not. cmiiw

User.findByIdAndUpdate(req.params.id, userTemp, function(err, user){ console.log("error:",err);res.send(user); };

answered Aug 05 '17 at 16:14

Sofyan Qusyairi

11
1

Yeah it's null but there is a user with the ID passed which is weird. – Ed Lynch Aug 05 '17 at 17:22
May not enter condition inside if. items._id is ObjectID, right? you can use method .equals , or parse first with toString() – Sofyan Qusyairi Aug 06 '17 at 00:19

score 0 · Answer 2 · answered Aug 05 '17 at 15:40

0

To delete you can do so. But if to change status only you need to do update yourself.. Post the parameters you are passing

    User.findOneAndRemove({_id: req.params.id }, function(err){...})

answered Aug 05 '17 at 15:40

jcardoso

61
7

That will remove the entire user wont it? I only want to remove an item stored in the user model. – Ed Lynch Aug 05 '17 at 15:49

API Delete not updating DB

2 Answers2