Will My order number generator work correctly?

Asked Jul 31 '17 at 07:51

Active Jul 31 '17 at 08:43

Viewed 85 times

I need order number,that is not order ID but is unique. I generate from time,member id,random. ...

bll.DataAccess.BeginTransaction();            
    try
    {
        T_ProductOrd order = new T_ProductOrd();
        DateTime tm = DateTime.Now;
        order.F_MemberID = user.F_MemberID;
        order.F_Status = (short)OrderStatus.waitpay;
        order.F_Price = items.Sum(i => i.num * i.price);
        do {                 
            order.F_OrderNum = tm.ToString("yyyyMMdd") + (user.F_MemberID % 1000).ToString("0000") + new Random((int)tm.Ticks).Next(0, 9999).ToString("0000");
            bll.Save(order);
        } while (bll.FindCount(p => p.F_OrderNum == order.F_OrderNum) > 1);

My question is :do...while query and regenerate in database transaction will work fine?or still possible throw unique conflict when commit? If is not work fine 100%.how can I fixed?

edited Jul 31 '17 at 08:43

Habeeb

7,601
1
30
33

asked Jul 31 '17 at 07:51

fe263

9

Why not just use `Guid`? – Aleks Andreev Jul 31 '17 at 07:54
It's rather unlikely that at the same time persons with the same member ID will register, right? – Ian H. Jul 31 '17 at 07:54
What are you trying to achieve in the `do while`? It currently looks like you're _saving duplicates_ until you finally save a unique one. – C.Evenhuis Jul 31 '17 at 07:55
Guid is not Human-readable.and member ID I only use low four bit orelse is too long – fe263 Jul 31 '17 at 07:57
Refer [this SO on GUID](https://stackoverflow.com/questions/371762/what-exactly-is-guid-why-and-where-i-should-use-it) – Siva Gopal Jul 31 '17 at 07:57
If you already have a database, why not simply use it's built in auto-increment mechanism instead of creating your own? – Zohar Peled Jul 31 '17 at 08:05
@Zohar Peled I need other order number for user query.database auto id is not good idea for remember. – fe263 Jul 31 '17 at 08:10

Will My order number generator work correctly?

0 Answers0