Writing many variables into textfile

Question

I've this piece of code:

using (StreamWriter writer = new StreamWriter("C:\\Users\\HP8200\\Desktop\\teste.txt"))
{            
    string numcont = _transaction.PartyFederalTaxID;

    double numenc = _transaction.BillToPartyID;
    double numfatura = _transaction.BillToPartyID;
    string zona = _transaction.BillToPartyCountryID;
    DateTime data = _transaction.CreateDate;
    string ean = _transaction.ATDocCodeId;
    double iva = _transaction.TotalTaxAmount;
    double precoantesdisc = _transaction.TotalLineItemDiscountAmount;
    double preconet = _transaction.TotalNetAmount;

    writer.WriteLine(numcont,";", numenc,";", numfatura,";", data,";", zona, Environment.NewLine , 
        ean,";", iva,";", precoantesdisc,";", preconet);
}

MessageBox.Show("gravou");

And it should save all those variables into the textfile I say but it only writes the first variable(numcont). What I need to do so it writes all the variables I need on that textfile? Feel free to ask for more code.

Romano Zumbé · Accepted Answer · 2017-07-26T10:27:59.363

7

You need to format the string:

writer.WriteLine(string.Format("{0};{1};{2};{3};{4}{5}{6};{7};{8};{9}",numcont, numenc, numfatura, data.ToString(), zona, Environment.NewLine, ean, iva, precoantesdisc, preconet));

If you can use C# 6 syntax:

writer.WriteLine($"{numcont};{numenc};{numfatura};{data.ToString()};{zona}{Environment.NewLine}{ean};{iva};{precoantesdisc};{preconet}");

EDIT

Use only day, month and year:

writer.WriteLine($"{numcont};{numenc};{numfatura};{data.ToString("yyyyMMdd")};{zona}{Environment.NewLine}{ean};{iva};{precoantesdisc};{preconet}");

The patter "yyyMMdd" can be arranged as you want. For example "dd.MM.yyyy"

edited Jul 26 '17 at 10:27

answered Jul 26 '17 at 09:39

Romano Zumbé

7,893
4
33
55

3

I think you are missing a final parenthesis... :) – Pikoh Jul 26 '17 at 09:41
It worked, you missed a ")" in the end but no problem, thanks – joao costa Jul 26 '17 at 09:47
@RomanoZumbé I need a line break between zona and ean, but nothing seems to work. I've tryed with the Environment.NewLine and didnt work as well. Any clue on whats wrong? – joao costa Jul 26 '17 at 10:25

score 5 · Answer 2 · answered Jul 26 '17 at 09:38

5

just do the following

you have to concatenate all variables in a variable and then pass it as an argument

var line = numcont +";"+ numenc+";"+ numfatura+";"+ data+";"+ zona +Environment.NewLine + ean+";"+ iva+";"+ precoantesdisc+";"+ preconet; 



writer.WriteLine(line);

or for readibilty reasons

var  line =string.Format("{0};{1};{2};{3};{4}\n{5};{6};{7};{8}",numcont, numenc, numfatura, data.ToString(), zona, ean, iva, precoantesdisc, preconet);

answered Jul 26 '17 at 09:38

BRAHIM Kamel

13,492
1
36
47

Just one more question, if possible, On the date variable, it cames with the hours, minutes and seconds, is it possible to hide? – joao costa Jul 26 '17 at 09:59
@joaocosta see the edit in my answer for the date part – Romano Zumbé Jul 26 '17 at 10:15

score 1 · Answer 3 · answered Jul 26 '17 at 09:44

Use File.WriteAllText() will simplify your code, try run this example online:

public static void Main()
{
    string numcont = "abc";

    double numenc = 1.1;
    double numfatura = 12.2;
    string zona = "def";
    DateTime data = new DateTime();
    string ean = "hij";
    double iva = 23.4;
    double precoantesdisc = 34.5;
    double preconet = 45.6;
    var info =  numcont + ";" + numenc + ";" + numfatura + ";" + data + ";"
                + zona + Environment.NewLine + ean +";" + iva + ";" + 
                precoantesdisc +";" + preconet;
    File.WriteAllText("abc.txt",info);

    Console.Write(info);
}

score 1 · Answer 4 · answered Jul 26 '17 at 09:55

If you look at the method StreamWriter.WriteLine you will see that none of the overloads matches the pattern of parameters that you feed into the method.

Up to now you are calling this overload with the signature of:

public virtual void WriteLine(<br> string format,<br> params object[] arg<br> )

The documentation says about the parameter arg

An object array that contains zero or more objects to format and write....
The format parameter consists of zero or more runs of text intermixed with zero or more indexed placeholders, called format items, that correspond to an object in the parameter list of this method. The formatting process replaces each format item with the string representation of the value of the corresponding object.

This seems not what you want.

One often used method for the display of an object is to override the ToString method.

public override string ToString()
{
    return $"{PartyFederalTaxID};{BillToPartyID};{CreateDate};{BillToPartyCountryID}" + Environment.NewLine + 
    $"{ATDocCodeId};{TotalTaxAmount}{TotalLineItemDiscountAmount}{TotalNetAmount}"
}

this will allow you to determine the format and you could simply dump the entire object as parameter into the WriteLine method. The ToString method will be called automatically:

writer.WriteLine(_transaction);

score 0 · Answer 5 · answered Aug 16 '17 at 09:57

You can also use string.Concat() as it will concatenate all the values to a string

writer.WriteLine(string.Concat(numcont,";", numenc,";", numfatura,";", data,";", zona, Environment.NewLine , 
    ean,";", iva,";", precoantesdisc,";", preconet));

or

StreamWriter.WriteLine(string format, params object[] arg)

overload method as below

writer.WriteLine("{0};{1};{2};{3};{4};{5};{6}:{7};{8};{9}", numcont, numenc, numfatura, data, zona, Environment.NewLine,
                ean, iva, precoantesdisc, preconet);

Writing many variables into textfile

5 Answers5