Error due to invalid combination of Toast and OnClickListener

Question

I'm trying to use Toast inside OnCLickListener. My code triggers the following error:

The method makeText(Context, CharSequence, int) in the type Toast is not applicable for the arguments (new View.OnClickListener(){}, String, int)

This is my code:

    Button register = (Button) findViewById(R.id.register);
    register.setOnClickListener(new View.OnClickListener() {
        public void onClick(View arg0) {
            EditText name = (EditText)findViewById(R.id.name);
            String Lname = name.getText().toString();

            Toast.makeText(this, Lname, Toast.LENGTH_SHORT).show();



        }
    });

score 94 · Accepted Answer · answered Dec 25 '10 at 20:24

94

As The Kenny said, this is refering to the View.OnClickListener instead of your Activity. Change this, to MyActivity.this.

For example,

public class MyActivity extends Activity {
// ... other code here
Toast.makeText(MyActivity.this, Lname, Toast.LENGTH_SHORT).show();

answered Dec 25 '10 at 20:24

Computerish

9,590
7
38
49

2

MyActivity.this. Thanks. Couldn't remember how to refer to the this of the enclosing class. – jsadfeew Dec 25 '10 at 20:28
1

The Kenny - I can't tell you how many times I've seen questions just like this on SO. Every single time I have to look it up in my source code. You'd think I would learn. – Computerish Dec 25 '10 at 20:31
apart from myActivity.this you can also use getApplicationContext() – Rishabh Agrawal Sep 09 '15 at 14:48

score 7 · Answer 2 · edited Feb 08 '14 at 05:58

7

In this case, this refers to the instance of the anonymous subclass of View.OnClickListener. You have to refer to the this of the class where you create the anonymous class.

edited Feb 08 '14 at 05:58

aboger

2,214
6
33
47

answered Dec 25 '10 at 20:19

jsadfeew

2,247
1
18
25

score 4 · Answer 3 · edited May 14 '13 at 09:22

4

Use MyActivity.this as this refers to your onclickListener.

edited May 14 '13 at 09:22

Chintan Khetiya

15,962
9
47
85

answered May 14 '13 at 09:01

Mr.India

674
2
9
19

score 3 · Answer 4 · edited Feb 08 '14 at 05:50

3

You can use getApplicationContext() as well. See the documentation.

edited Feb 08 '14 at 05:50

aboger

2,214
6
33
47

answered Feb 16 '13 at 10:15

Jock Mahon

116
1
9

score 2 · Answer 5 · answered Jun 10 '12 at 04:31

Anywhere, just use the following:

((Activity) mContext).runOnUiThread(new Runnable() {
                    public void run() {
                        Toast my_toast = Toast.makeText(mContext, "YOUR TEXT OR STRING", Toast.LENGTH_LONG);
                        my_toast.setGravity(Gravity.CENTER, 0, 0);
                        my_toast.show();
                    }
                });

You just need to define at the top of your activity (just after the onCreate):

mContext = this;

Also, see that I decomposed it a bit to be able to handle the gravity as I want (sometimes you may want the toast to appear at the center of the screen)...

score 1 · Answer 6 · edited Feb 08 '14 at 05:50

Another approach to achieve your goal is to implement the OnClickListener interface. This way you implement the onClick() method in your Activity and you could thus assign this. In addition, you can assign this to multiple Buttons. You can distinguish these Buttons from each other by comparing their IDs via an appropriate if, respectively switch statement within the onClick() method.

public class MyActivity extends Activity implements OnClickListener{

    // ...

    protected void onCreate (Bundle savedInstanceState){
        // ...
        Button register = (Button) findViewById(R.id.register);
        register.setOnClickListener(this); 
    }

    public void onClick(View arg0) {
        EditText name = (EditText) findViewById(R.id.name);
        String text = name.getText().toString();

        Toast.makeText(this, text, Toast.LENGTH_SHORT).show();
    }
}

score 0 · Answer 7 · answered Jul 27 '16 at 04:50

0

try this

 public void onClick(View arg0) {
        EditText name = (EditText)findViewById(R.id.name);
        String Lname = name.getText().toString();
        Toast.makeText(arg0.getContext(), Lname, Toast.LENGTH_SHORT).show();
    }

answered Jul 27 '16 at 04:50

Thamays

2,978
26
31

Error due to invalid combination of Toast and OnClickListener

7 Answers7

Related