After adding element in NSMutableArray previous elements gets replaced

Question

I'm working on app in which I want to create array with number of NSDictionary's. When i'm trying to add NSMutableDictionary in NSMutableArray, previously added elements of that array get replaced. I don't know what is happening. Code as follows:

var paynowArray = NSMutableArray()
let tempDict = NSMutableDictionary()
for i in 0...selectedEmenetsArray.count-1 {
    tempDict.removeAllObjects()
    tempDict.setValue(selectedIdAry[i], forKey: "serviceId")
    tempDict.setValue(selectedAmountAry[i], forKey: "serviceAmount")              
    paynowArray.add(tempDict)
}
print(paynowArray)

While printing array last added NSMutableDictionary printed n times.

Thanks in advance.

score 1 · Accepted Answer · answered Jun 27 '17 at 11:20

Create tempDict inside the for loop. You should allocate dictionary for every element. Else you are replacing the same memory location value every times.

var paynowArray = NSMutableArray()
for i in 0...selectedEmenetsArray.count-1 {

    var tempDict = NSMutableDictionary()

    tempDict.setValue(selectedIdAry[i], forKey: "serviceId")
    tempDict.setValue(selectedAmountAry[i], forKey: "serviceAmount")              
    paynowArray.add(tempDict)
}
print(paynowArray)

score 0 · Answer 2 · edited Jun 27 '17 at 11:33

0

Should be inside the loop..

let tempDict = NSMutableDictionary()

edited Jun 27 '17 at 11:33

Bilal

18,478
8
57
72

answered Jun 27 '17 at 11:21

Akash Singh Sisodia

137
1
12

After adding element in NSMutableArray previous elements gets replaced

2 Answers2