how to handle this in node js

Question

Currently I'm doing this:

filename : userOrder.js

const paymentGateway = require('./paymentGateway');

module.exports = {

        save: function() {

            // save user order record  
            return paymentGateway.makePayment();      

        },

        update: function() {

            // update user order record

        }

}

filename: paymentGateway.js

const payment = require('./payment');

module.exports = {

    makePayment: function() {

        // make payment
        return payment.save();

    }

}

filename : payment.js

const userOrder = require('./userOrder');

module.exports = {

        save: function() {

            // save payment record
            return userOrder.update();

        }

}

return userOrder.update(); -> this line gives an error "TypeError: userOrder.update is not a function"

Other code is only for save record nothing else. – Hiren Makwana Jun 20 '17 at 14:12 — Hiren Makwana, Jun 20 '17 at 14:12

dan · Accepted Answer · 2017-06-20T14:41:30.540

1

This is because you are using circular references between payment.js and userOrder.js. You can fix this by assigning a value to module.exports before you call require, like this:

userOrder.js

const userOrder = function() { };

module.exports = userOrder;

const paymentGateway = require('./paymentGateway');

userOrder.save = function() {
    // save user order record  
    return paymentGateway.makePayment(); 
}

userOrder.update = function() {
    // update user order record
}

payment.js

const payment = function() {};

module.exports = payment;

const userOrder = require('./userOrder');

payment.save = function() {
    // save payment record
    return userOrder.update();
}

No changes are required to paymentGateway.js, as this isn't part of a circular require.

edited Jun 20 '17 at 14:41

answered Jun 20 '17 at 14:31

dan

1,944
1
15
22

Okay, let me try, i've also updated question.. Thanks – Hiren Makwana Jun 20 '17 at 14:36
Cool. I'll update my answer to match the updated question. – dan Jun 20 '17 at 14:36
@HirenMakwana no problem :) – dan Jun 20 '17 at 14:55

score 0 · Answer 2 · answered Jun 20 '17 at 14:12

0

Try with :

module.exports = {

    module.save = function() {

        // save user order record  
        return payment.save();      

    },

    module.update = function() {

        // update user order record

    }

    return module;
}

answered Jun 20 '17 at 14:12

Valentin Duboscq

970
8
20

how to handle this in node js

2 Answers2